Skip to content

Commit 910462a

Browse files
committed
Test every fan in a separate subtest
1 parent b9ecde4 commit 910462a

1 file changed

Lines changed: 26 additions & 25 deletions

File tree

‎cuda_core/tests/system/test_system_device.py‎

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -635,36 +635,37 @@ def test_fan(subtests):
635635
pytest.skip("Device has no fans to test")
636636

637637
for fan_idx in range(device.num_fans):
638-
fan_info = device.get_fan(fan_idx)
639-
assert isinstance(fan_info, _device.FanInfo)
638+
with subtests.test(fan_idx=fan_idx):
639+
fan_info = device.get_fan(fan_idx)
640+
assert isinstance(fan_info, _device.FanInfo)
640641

641-
speed = fan_info.speed
642-
assert isinstance(speed, int)
643-
assert 0 <= speed <= 200
644-
try:
645-
fan_info.speed = 50
646-
except nvml.NoPermissionError as e:
647-
pytest.xfail(f"nvml.NoPermissionError: {e}")
648-
try:
649-
fan_info.speed = speed
642+
speed = fan_info.speed
643+
assert isinstance(speed, int)
644+
assert 0 <= speed <= 200
645+
try:
646+
fan_info.speed = 50
647+
except nvml.NoPermissionError as e:
648+
pytest.xfail(f"nvml.NoPermissionError: {e}")
649+
try:
650+
fan_info.speed = speed
650651

651-
speed_rpm = fan_info.speed_rpm
652-
assert isinstance(speed_rpm, int)
653-
assert speed_rpm >= 0
652+
speed_rpm = fan_info.speed_rpm
653+
assert isinstance(speed_rpm, int)
654+
assert speed_rpm >= 0
654655

655-
target_speed = fan_info.target_speed
656-
assert isinstance(target_speed, int)
657-
assert speed <= target_speed * 2
656+
target_speed = fan_info.target_speed
657+
assert isinstance(target_speed, int)
658+
assert speed <= target_speed * 2
658659

659-
min_, max_ = fan_info.min_max_speed
660-
assert isinstance(min_, int)
661-
assert isinstance(max_, int)
662-
assert min_ <= max_
660+
min_, max_ = fan_info.min_max_speed
661+
assert isinstance(min_, int)
662+
assert isinstance(max_, int)
663+
assert min_ <= max_
663664

664-
control_policy = fan_info.control_policy
665-
assert isinstance(control_policy, typing.FanControlPolicy)
666-
finally:
667-
fan_info.set_default_speed()
665+
control_policy = fan_info.control_policy
666+
assert isinstance(control_policy, typing.FanControlPolicy)
667+
finally:
668+
fan_info.set_default_speed()
668669

669670

670671
def test_cooler(subtests):

0 commit comments

Comments
 (0)