Skip to content

Commit 8ce0a8b

Browse files
committed
build: fix -std=c++17 typo in cuda.core gnu/llvm flags (regression from dedup)
The dedup refactor accidentally changed gcc's '-std=c++17' (equals) to '-std:c++17' (colon) in cuda_core/build_hooks.py's gnu and llvm branches. gcc rejects the colon form ('unrecognized command-line option'), breaking all Linux gcc builds of cuda.core (the pixi smoke build and the linux-aarch64 wheel builds). cuda.bindings was unaffected (it uses -std=c++14, correctly). Restore the equals form.
1 parent f8245a5 commit 8ce0a8b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎cuda_core/build_hooks.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,14 @@ def _resolve_toolchain(debug=False, compile_for_coverage=False):
205205
if debug:
206206
raise RuntimeError("Debuggable builds are not supported on Windows.")
207207
elif name == "gnu":
208-
extra_compile_args += ["-std:c++17"]
208+
extra_compile_args += ["-std=c++17"]
209209
if debug:
210210
extra_compile_args += ["-g", "-O0", "-D _GLIBCXX_ASSERTIONS"]
211211
else:
212212
extra_compile_args += ["-g0", "-O2"]
213213
extra_link_args += ["-Wl,--strip-all"]
214214
elif name == "llvm":
215-
extra_compile_args += ["-std:c++17"]
215+
extra_compile_args += ["-std=c++17"]
216216
extra_link_args += ["-fuse-ld=lld"]
217217
if debug:
218218
extra_compile_args += ["-g", "-O0", "-D _GLIBCXX_ASSERTIONS"]

0 commit comments

Comments
 (0)