Skip to content

Commit 88a2ab3

Browse files
committed
Simplify Cython test installation and align release guidance
Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>
1 parent 07e4d39 commit 88a2ab3

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

‎.github/RELEASE-bindings.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ cybind inputs instead of blindly copying generated output between majors.
5555
branch. Normal development CI includes dependent packages and may cover
5656
both majors. Resolve failures in affected code before selecting the tag.
5757
3. Create the approved immutable `vX.Y.Z` tag at the selected source commit.
58-
Tag-triggered CI builds both bindings lines and their consumers. The release
59-
workflow selects only the requested line's bindings or metapackage artifacts.
58+
Tag-triggered CI selects that line's bindings and metapackage, validates them
59+
with the published Pathfinder dependency, and builds release artifacts.
6060
The tag does not have to be on `main`. Wait for this exact tag's CI to pass.
6161
4. Run **CI: Release** with `release-action=dry-run`, the tag, and
6262
`component=cuda-bindings`; repeat for `cuda-python`. Leave `run-id` blank

‎.github/workflows/build-wheel.yml‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -581,12 +581,7 @@ jobs:
581581
bindings_wheels=(${{ env.CURRENT_BINDINGS_ARTIFACTS_DIR }}/*.whl)
582582
test "${#bindings_wheels[@]}" -eq 1
583583
test -f "${bindings_wheels[0]}"
584-
bindings_pyproject="${CURRENT_BINDINGS_ROOT}/pyproject.toml"
585-
if grep -q '^\[dependency-groups\][[:space:]]*$' "${bindings_pyproject}"; then
586-
python -m pip install "${bindings_wheels[0]}" --group "${bindings_pyproject}:test"
587-
else
588-
python -m pip install "${bindings_wheels[0]}[test]"
589-
fi
584+
python -m pip install "${bindings_wheels[0]}" --group "${CURRENT_BINDINGS_ROOT}/pyproject.toml:test"
590585
pushd ${{ env.CURRENT_BINDINGS_CYTHON_TESTS_DIR }}
591586
bash build_tests.sh
592587
popd

0 commit comments

Comments
 (0)