Skip to content

Commit 792c5e1

Browse files
Andy-Jostclaude
andcommitted
docs: make the floor release checks actionable
Name the CI run and the log line for the floor check, and say that standard CI does not install the CUDA 12 floor. Require a new floor to be released on PyPI first. Drop a dangling "also". Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 226e394 commit 792c5e1

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

‎.github/RELEASE-core.md‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,12 @@ cuda-bindings floor" in `cuda_core/AGENTS.md`. Check the floors instead:
9595
major in `ci/versions.yml` (`build` for the current major, `prev_build`
9696
for the prior major). If a floor's minor is lower, the toolkit-bump
9797
window is open: move the floor before the release.
98-
- The CI rows with `BINDINGS_SOURCE=floor` installed the literal floor.
99-
Their logs show `cuda-bindings==<floor>` and no "predates ... headers"
100-
line.
98+
- In the latest CI run on `main`, the CUDA 13 rows whose CUDA minor
99+
differs from the `build` pin (for example "CUDA 13.0.2") installed the
100+
literal floor. Their logs show `Installing bindings (source: floor)` and
101+
`cuda-bindings==<floor>`, and no "predates ... headers" line. Standard
102+
CI does not install the CUDA 12 floor: its rows use the 12.9.x backport
103+
build.
101104
- The release notes list every floor move since the last release under
102105
"Breaking Changes".
103106

‎cuda_core/AGENTS.md‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,10 @@ qualifies.
6262
Three events move a floor:
6363

6464
- A change uses a `cuda-bindings` API newer than the floor. Bump the floor in
65-
the same pull request.
65+
the same pull request. The new floor must already be released on PyPI;
66+
release `cuda-bindings` first.
6667
- A change relies on a bug fix in a newer `cuda-bindings`. Bump the floor in
67-
the same pull request.
68+
the same pull request, under the same condition.
6869
- The build toolkit moves to a new minor. Move the floor to the lowest
6970
suitable release of that minor, as described under "CUDA Toolkit minor
7071
bumps".
@@ -90,7 +91,7 @@ bump:
9091
5. Pin `cuda-bindings` to match in the conda-forge `cuda-core` feedstock. The
9192
feedstock lives outside this repository.
9293

93-
A `cuda-core` release also bumps the `cuda-core~=X.Y.0` pin in
94+
A `cuda-core` release bumps the `cuda-core~=X.Y.0` pin in
9495
`cuda_python/setup.py`, followed by a `cuda-python` release (see
9596
`.github/RELEASE-core.md`).
9697

0 commit comments

Comments
 (0)