Repository navigation
Commit 6fd6b6c
Address review: scope cache perms to tmp, revert cybind docstring
Per @leofang's review on PR #2399:
- _file_stream.py: only the tmp/ staging dir is created owner-only (0o700).
root/ and entries/ now inherit the umask / any pre-existing permissions so a
deliberately shared kernel cache (e.g. group-writable on a compute cluster)
keeps working. Dropped the post-mkdir chmod that would have re-tightened an
existing shared directory. 0o700 in mkdir mode needs no chmod: umask only
clears bits.
- _internal/utils.pyx: revert the get_buffer_pointer docstring change; that is
cybind code and is out of scope for this PR.
- Tests updated to match: assert only tmp is 0o700, and that a pre-existing
0o777 shared root is used as-is.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>1 parent 1d74206 commit 6fd6b6c
3 files changed
Lines changed: 24 additions & 30 deletions
File tree
- cuda_bindings/cuda/bindings/_internal
- cuda_core
- cuda/core/utils/_program_cache
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
| 45 | + | |
52 | 46 | | |
53 | 47 | | |
54 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
397 | 397 | | |
398 | 398 | | |
399 | 399 | | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
406 | 409 | | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | 410 | | |
411 | 411 | | |
412 | 412 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2539 | 2539 | | |
2540 | 2540 | | |
2541 | 2541 | | |
2542 | | - | |
2543 | | - | |
2544 | | - | |
2545 | | - | |
2546 | | - | |
| 2542 | + | |
| 2543 | + | |
| 2544 | + | |
| 2545 | + | |
| 2546 | + | |
2547 | 2547 | | |
2548 | 2548 | | |
2549 | 2549 | | |
2550 | 2550 | | |
2551 | 2551 | | |
2552 | 2552 | | |
2553 | 2553 | | |
2554 | | - | |
2555 | | - | |
2556 | | - | |
| 2554 | + | |
| 2555 | + | |
2557 | 2556 | | |
2558 | 2557 | | |
2559 | 2558 | | |
2560 | | - | |
2561 | | - | |
2562 | | - | |
2563 | | - | |
| 2559 | + | |
| 2560 | + | |
| 2561 | + | |
| 2562 | + | |
2564 | 2563 | | |
2565 | 2564 | | |
2566 | 2565 | | |
2567 | 2566 | | |
2568 | 2567 | | |
2569 | 2568 | | |
2570 | | - | |
| 2569 | + | |
2571 | 2570 | | |
2572 | 2571 | | |
2573 | 2572 | | |
2574 | 2573 | | |
2575 | | - | |
| 2574 | + | |
| 2575 | + | |
0 commit comments