Skip to content

Commit 5762894

Browse files
committed
CI: match the specific emSign root in the install-sccache roots check
webpki-roots 1.0.10 removes only emSign ECC Root CA - G3 and keeps the other emSign roots, so grepping for 'emSign' would reject a fixed root list. Signed-off-by: Ralf Juengling <[email protected]>
1 parent 4b09d11 commit 5762894

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

‎.github/actions/install-sccache/action.yml‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,14 @@ description: Download, verify, and install a pinned rapidsai/sccache binary on L
1414
# Security note (eMudhra/emSign CA incident):
1515
# - Every version bump MUST repeat the embedded-roots check on the extracted
1616
# `sccache` binary:
17-
# grep -ac 'ISRG Root X1' sccache # >0 means a root list is embedded
18-
# grep -ac 'emSign' sccache # must be 0
17+
# grep -ac 'ISRG Root X1' sccache # >0 means a root list is embedded
18+
# grep -ac 'emSign ECC Root CA - G3' sccache # must be 0
1919
# Pass criteria: either no embedded root list (both return 0; binary defers
2020
# to the OS trust store via `rustls-platform-verifier`, as verified for
2121
# `rapidsai/sccache` v0.18.0-rapids.7), or an embedded `webpki-roots` list
22-
# at 1.0.10+ where `ISRG Root X1` matches and `emSign` returns 0.
22+
# at 1.0.10+ where `ISRG Root X1` matches and `emSign ECC Root CA - G3`
23+
# returns 0. Match the full root name: 1.0.10 removes only that emSign root
24+
# and still ships other emSign roots.
2325
# - Do NOT switch to or bump `mozilla/sccache` to v0.19.0 (or later without
2426
# repeating the roots check): `mozilla/sccache` v0.19.0 re-embeds
2527
# `webpki-roots` 1.0.5, which still trusts `emSign ECC Root CA - G3`.

0 commit comments

Comments
 (0)