Repository navigation
Commit 35d1722
cuda.core: keep kernel-argument objects alive in graph kernel nodes (#2041)
* cuda.core: keep kernel-argument objects alive in graph kernel nodes
`GraphDefinition.launch()` did not extend the lifetime of the Python
kernel-argument objects to the lifetime of the graph. The `ParamHolder`
built in `GN_launch` held the only references to those objects and was
destroyed when `GN_launch` returned. The driver only stores the raw
pointer values in the kernel node, so a `Buffer` reachable only through
the call could be GC'd before the graph ran, leaving the graph with a
stale device pointer.
Attach the `kernel_args` tuple to the graph as a CUDA user object,
mirroring the existing handling of `KernelHandle` and `EventHandle`.
This reuses the `_py_host_destructor` path already used by the host
callback machinery.
Closes #2039
Co-authored-by: Cursor <[email protected]>
* test: assert kernel-arg Buffer is freed when graph is released
Addresses review feedback (PR #2041): the existing test only proved the
graph kept the Buffer alive, not that the user-object machinery actually
releases it once the graph is destroyed. Without the symmetric check, a
working attachment is indistinguishable from a permanent leak.
Co-authored-by: Cursor <[email protected]>
* test: poll for kernel-arg Buffer release to handle async cleanup
The freeing assertion at the end of test_kernel_args_buffer_lifetime
failed on free-threaded Python (py3.14t) because cuGraphExecDestroy
releases its user-object references via an asynchronous DPC, and free-
threaded CPython's deferred ref counting can need an extra GC pass to
settle. Poll the weakref with a bounded timeout and per-iteration GC
instead of asserting eagerly.
Co-authored-by: Cursor <[email protected]>
---------
Co-authored-by: Cursor <[email protected]>1 parent 57a538c commit 35d1722
3 files changed
Lines changed: 117 additions & 1 deletion
File tree
- cuda_core
- cuda/core/graph
- tests/graph
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
| |||
54 | 56 | | |
55 | 57 | | |
56 | 58 | | |
| 59 | + | |
57 | 60 | | |
58 | 61 | | |
59 | 62 | | |
| |||
617 | 620 | | |
618 | 621 | | |
619 | 622 | | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
620 | 629 | | |
621 | 630 | | |
622 | 631 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
10 | 12 | | |
11 | 13 | | |
12 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
| 8 | + | |
| 9 | + | |
7 | 10 | | |
8 | 11 | | |
9 | 12 | | |
10 | 13 | | |
11 | 14 | | |
12 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
13 | 34 | | |
14 | 35 | | |
15 | 36 | | |
| |||
485 | 506 | | |
486 | 507 | | |
487 | 508 | | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
| 586 | + | |
| 587 | + | |
| 588 | + | |
| 589 | + | |
| 590 | + | |
| 591 | + | |
| 592 | + | |
0 commit comments