Skip to content

Commit 1e23b52

Browse files
committed
Clarify version-neutral package names after source-root rename
Signed-off-by: Ralf W. Grosse-Kunstleve <[email protected]>
1 parent e496596 commit 1e23b52

6 files changed

Lines changed: 11 additions & 11 deletions

File tree

‎.github/workflows/ci-pixi-source-test.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ jobs:
131131
# The round trip (not just cu13 -> cu12) is what catches the second half:
132132
# coming back to cu13 must not silently reuse the cu12 extension.
133133
#
134-
# cuda_core only: cuda_bindings_13 cannot be source-built in its cu12
134+
# cuda_core only: cuda-bindings cannot be source-built in its cu12
135135
# environment at all, for reasons unrelated to stale artifacts.
136136
build-identity-roundtrip:
137137
name: "cu13 -> cu12 -> cu13 round trip (linux-64, CPU)"

‎.github/workflows/ci.yml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -122,13 +122,13 @@ jobs:
122122
#
123123
# Dependency graph (verified in pyproject.toml files):
124124
# cuda_pathfinder -> (no internal deps)
125-
# cuda_bindings_13 -> cuda_pathfinder
126-
# cuda_core -> cuda_pathfinder, cuda_bindings_13
127-
# cuda_python -> cuda_pathfinder, cuda_bindings_13, cuda_core (meta package)
125+
# cuda_bindings -> cuda_pathfinder
126+
# cuda_core -> cuda_pathfinder, cuda_bindings
127+
# cuda_python -> cuda_pathfinder, cuda_bindings, cuda_core (meta package)
128128
#
129129
# A change to cuda_pathfinder (or shared infra) forces a rebuild of every
130-
# downstream module. A change to cuda_bindings_13 forces rebuild of cuda_core.
131-
# A change to cuda_core alone skips rebuilding/retesting cuda_bindings_13 and
130+
# downstream module. A change to cuda_bindings forces rebuild of cuda_core.
131+
# A change to cuda_core alone skips rebuilding/retesting cuda_bindings and
132132
# cuda_pathfinder, but still retests the downstream cuda-python metapackage.
133133
# Shared build/orchestration changes run the full pipeline; test-only CI
134134
# infrastructure runs every test suite without rebuilding package wheels.

‎cuda_core/AGENTS.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ This file describes `cuda_core`, the high-level Pythonic CUDA subpackage in the
2323
one `_cpp/<name>.cpp` or as a directory `_cpp/<name>/` whose sources all
2424
compile into the `_<name>` extension (`_cpp/rt/` for `_rt`).
2525
- **Build backend**: `build_hooks.py` handles Cython extension setup and build
26-
dependency wiring. Logic shared with `cuda_bindings_13` (toolchain selection,
26+
dependency wiring. Logic shared with `cuda-bindings` (toolchain selection,
2727
the compiler flag set, the Cython cache helpers and the rebuild stamps)
2828
lives in `_build_shared.py`. `cuda_bindings_13/_build_shared.py` is canonical;
2929
`cuda_core/_build_shared.py` must be either a symlink to it or a byte-for-byte

‎cuda_core/pyproject.toml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ test = [
7979
"psutil==7.2.2; sys_platform != 'win32' or python_version < '3.15'",
8080
"packaging>=24",
8181
"docutils==0.23",
82-
# Required by tests/test_graphics.py; pinned to match cuda_bindings_13.
82+
# Required by tests/test_graphics.py; pinned to match cuda-bindings.
8383
"pyglet==2.1.14",
8484
"cffi==2.1.1",
8585
]

‎cuda_core/tests/AGENTS.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ Follow these rules when adding or moving shared test code:
109109
before adding a new helper; consolidate duplicates across
110110

111111
packages into `cuda_python_test_helpers` (both `cuda_core` and
112-
`cuda_bindings_13` test environments already depend on it).
112+
`cuda-bindings` test environments already depend on it).
113113
- Fixtures in a nested `conftest.py` are available to tests in its directory
114114
and descendants; fixtures from applicable parent `conftest.py` files remain
115115
available.

‎cuda_python_test_helpers/cuda_python_test_helpers/graphics.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
"""Shared GL helpers for graphics interop tests.
66
7-
Both ``cuda_core`` and ``cuda_bindings_13`` graphics tests need to skip
7+
Both ``cuda_core`` and ``cuda_bindings`` graphics tests need to skip
88
when the GL backend cannot be made current, and that decision must not
99
hide real bugs in the tests' own GL allocation code. This module owns the
1010
shared predicate so the two test suites stay in sync.
@@ -135,7 +135,7 @@ def tcc_skip_reason() -> str | None:
135135
OpenGL support, so CUDA-GL interop is unavailable on a TCC device. The
136136
check queries the currently-selected device via the CUDA runtime API
137137
(``cuda.bindings``) rather than ``cuda.core``, so both the ``cuda_core``
138-
and ``cuda_bindings_13`` graphics tests can share it without the latter
138+
and ``cuda_bindings`` graphics tests can share it without the latter
139139
taking a ``cuda.core`` dependency.
140140
141141
Runtime query failures (e.g. no CUDA device) propagate rather than being

0 commit comments

Comments
 (0)