Skip to content

feat(fern): adopt global-theme nvidia, remove per-repo theme assets#995

Merged
mchmarny merged 2 commits into
NVIDIA:mainfrom
pdmack:pdmack/fern-global-theme
May 21, 2026
Merged

feat(fern): adopt global-theme nvidia, remove per-repo theme assets#995
mchmarny merged 2 commits into
NVIDIA:mainfrom
pdmack:pdmack/fern-global-theme

Conversation

@pdmack

@pdmack pdmack commented May 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Switch to Fern's centralized global-theme: nvidia and remove per-repo theme assets. Adds multi-source: true to replace deprecated experimental.basepath-aware.

Motivation / Context

Fixes: #994
Related: NVIDIA/topograph#339, NVIDIA/topograph#340, NVIDIA/NVSentinel#1320, NVIDIA/NVSentinel#1321

Type of Change

  • New feature (non-breaking change that adds functionality)
  • Build/CI/tooling

Component(s) Affected

  • Docs/examples (docs/, examples/)

Implementation Notes

fern/docs.yml changes:

  • Added global-theme: nvidia — Fern hosts the NVIDIA theme centrally
  • Added multi-source: true on instance — replaces experimental.basepath-aware: true
  • Removed: footer, logo (dark/light/height), favicon, css, colors, theme, layout, js (Adobe Launch analytics) — all inherited from global theme
  • Kept: logo.href and logo.right-text (product-specific)
  • Removed: experimental block entirely

fern/fern.config.json:

  • Bumped Fern CLI from 4.62.4 to 5.30.2 (required for global-theme support)

Deleted files (1,135 lines removed):

  • fern/assets/NVIDIA_dark.svg, NVIDIA_light.svg, NVIDIA_symbol.svg
  • fern/components/CustomFooter.tsx, BadgeLinks.tsx
  • fern/main.css

Matches the pattern adopted by topograph and NVSentinel.

Testing

Structural parity with NVIDIA/topograph (merged #339, #340) and NVIDIA/NVSentinel (merged #1320).

Risk Assessment

  • Low — Isolated change, well-tested, easy to revert

Rollout notes: Requires a workflow_dispatch after merge to publish with the new theme. The global theme is already live on topograph and NVSentinel.

Checklist

  • I did not skip/disable tests to make CI green
  • Changes follow existing patterns in the codebase
  • Commits are cryptographically signed (git commit -S)

@pdmack pdmack requested a review from a team as a code owner May 21, 2026 00:07
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

🌿 Preview your docs: https://nvidia-preview-pdmack-fern-global-theme.docs.buildwithfern.com/aicr

@coderabbitai

coderabbitai Bot commented May 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 7521f5ff-a67d-4db2-9730-5f72024173a8

📥 Commits

Reviewing files that changed from the base of the PR and between b6b4b55 and 5dcd83a.

⛔ Files ignored due to path filters (3)
  • fern/assets/NVIDIA_dark.svg is excluded by !**/*.svg
  • fern/assets/NVIDIA_light.svg is excluded by !**/*.svg
  • fern/assets/NVIDIA_symbol.svg is excluded by !**/*.svg
📒 Files selected for processing (5)
  • fern/components/BadgeLinks.tsx
  • fern/components/CustomFooter.tsx
  • fern/docs.yml
  • fern/fern.config.json
  • fern/main.css
💤 Files with no reviewable changes (3)
  • fern/components/BadgeLinks.tsx
  • fern/main.css
  • fern/components/CustomFooter.tsx
📝 Walkthrough

Walkthrough

This PR adopts Fern's centralized global-theme: nvidia, enabling all NVIDIA documentation sites to inherit logos, favicon, CSS, footer, colors, layout, and analytics from a single global theme. The Fern CLI is bumped to version 5.30.2 (required for global-theme support), and docs.yml is restructured to enable multi-source mode and reference the global theme. Per-repo theme components (BadgeLinks.tsx, CustomFooter.tsx) and stylesheet (main.css) are removed as they are now redundant and maintained centrally.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately summarizes the main change: adopting the global NVIDIA theme and removing per-repo assets.
Description check ✅ Passed The description is detailed and directly related to the changeset, explaining motivations, implementation details, and testing approach.
Linked Issues check ✅ Passed All objectives from issue #994 are met: global-theme added, multi-source enabled, per-repo assets removed, and Fern CLI bumped to 5.30.2.
Out of Scope Changes check ✅ Passed All changes are directly aligned with issue #994 objectives; no out-of-scope modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@mchmarny mchmarny enabled auto-merge (squash) May 21, 2026 01:35
@mchmarny mchmarny merged commit 940fb15 into NVIDIA:main May 21, 2026
32 checks passed
@pdmack pdmack deleted the pdmack/fern-global-theme branch June 10, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchmarny mchmarny mchmarny approved these changes

Assignees

@pdmack pdmack

Labels

size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature]: adopt Fern global-theme nvidia and remove per-repo theme assets

2 participants

@pdmack @mchmarny