Skip to content

feat(skyhook-customizations): use overrides and switch to nvidia_tuned#96

Merged
mchmarny merged 2 commits into
mainfrom
skyhook_better_tuned
Feb 13, 2026
Merged

feat(skyhook-customizations): use overrides and switch to nvidia_tuned#96
mchmarny merged 2 commits into
mainfrom
skyhook_better_tuned

Conversation

@ayuskauskas

@ayuskauskas ayuskauskas commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Related PR NVIDIA/nodewright-packages#16

Summary

Changed overlays and template data for skyhook-customizations

Motivation / Context

Substantially simplify the definition of skyhook tunings for various workloads and providers.

Fixes:
Related:

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Build/CI/tooling

Component(s) Affected

  • CLI (cmd/eidos, pkg/cli)
  • API server (cmd/eidosd, pkg/api, pkg/server)
  • Recipe engine / data (pkg/recipe)
  • Bundlers (pkg/bundler, pkg/component/*)
  • Collectors / snapshotter (pkg/collector, pkg/snapshotter)
  • Validator (pkg/validator)
  • Core libraries (pkg/errors, pkg/k8s)
  • Docs/examples (docs/, examples/)
  • Other: ____________

Implementation Notes

Testing

# Commands run (prefer `make qualify` for non-trivial changes)
make qualify

Risk Assessment

  • Low — Isolated change, well-tested, easy to revert
  • Medium — Touches multiple components or has broader impact
  • High — Breaking change, affects critical paths, or complex rollout

Rollout notes:

Checklist

  • Tests pass locally (make test with -race)
  • Linter passes (make lint)
  • I did not skip/disable tests to make CI green
  • I added/updated tests for new functionality
  • I updated docs if user-facing behavior changed
  • Changes follow existing patterns in the codebase
  • Commits are signed off (git commit -s) — DCO info

@ayuskauskas ayuskauskas requested a review from a team as a code owner February 11, 2026 21:28
@ayuskauskas ayuskauskas changed the title feat(skyhook-customizations): use overrides and switch to nvidia_tuned [WIP] feat(skyhook-customizations): use overrides and switch to nvidia_tuned Feb 11, 2026
@ayuskauskas ayuskauskas changed the title [WIP] feat(skyhook-customizations): use overrides and switch to nvidia_tuned feat(skyhook-customizations): use overrides and switch to nvidia_tuned Feb 12, 2026
…d for tuning

Substantially simplify the definition of skyhook tunings for various workloads and providers

@mchmarny mchmarny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mchmarny mchmarny merged commit c0d4ee6 into main Feb 13, 2026
10 checks passed
@mchmarny mchmarny deleted the skyhook_better_tuned branch February 13, 2026 00:03
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since it has been closed for 90 days with no further activity. Please open a new pull request for related changes.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants