fix(recipes): disable Dynamo ssh-keygen on Kind#670
Merged
mchmarny merged 1 commit intoApr 24, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe overlay Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mchmarny
previously approved these changes
Apr 24, 2026
d467146 to
fef6600
Compare
mchmarny
approved these changes
Apr 24, 2026
25 tasks
lockwobr
pushed a commit
that referenced
this pull request
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable the Dynamo MPI ssh-keygen Helm hook only for the
h100-kind-inference-dynamorecipe.Motivation / Context
The Kind GPU inference CI workload does not exercise Dynamo's MPI launch path, but the upstream chart still runs a pre-install/pre-upgrade ssh-keygen hook that pulls
bitnamisecure/git:latest. In run 24889208608, that hook repeatedly timed out and consumed most of the GPU job budget before the snapshot step was canceled.Fixes: N/A
Related: https://github.com/NVIDIA/aicr/actions/runs/24889208608/job/72876842190?pr=666
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
Adds an inline override under the Kind Dynamo leaf recipe:
This is intentionally scoped to
h100-kind-inference-dynamo; cloud Dynamo overlays continue to use the chart default.Testing
Results:
go test ./pkg/recipe/...passedmake lint-yamlpassedfalsemake qualifypassed, including race tests, coverage, lint, e2e, scan, and license checksRisk Assessment
Rollout notes: N/A
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info