fix(ci): surface fern generate errors in preview#650
Merged
Conversation
The fern generate command failure was swallowed by bash -e, preventing the error output from being printed. Add || true so the output is always visible in CI logs for debugging.
Contributor
Coverage Report ✅
Coverage BadgeNo Go source files changed in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
|| trueto thefern generatecommand so its error output is printed even when it exits non-zero.Motivation / Context
The fern docs preview workflow silently swallows errors because
bash -eaborts the script beforeecho "$OUTPUT"runs. This makes it impossible to diagnose failures like the one in run 24835193594.Fixes: N/A
Related: N/A
Type of Change
Component(s) Affected
cmd/aicr,pkg/cli)cmd/aicrd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
When
fern generateexits non-zero,bash -eterminates the step immediately — the captured output is never printed. Adding|| truelets the script continue toecho "$OUTPUT", making the actual Fern error visible in logs. The existing URL-empty guard still correctly fails the step when no preview URL is produced.Testing
CI-only change — no Go code affected.
Risk Assessment
Rollout notes: N/A
Checklist
make testwith-race)make lint)git commit -S) — GPG signing info