fix: add actions:read permission for artifact download#6
Merged
Conversation
The workflow_run workflow needs actions:read permission to download artifacts from other workflow runs. Without this, the download-artifact action fails with "Resource not accessible by integration". Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: Davanum Srinivas <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR adds the missing actions: read permission to the Post PR Comment workflow, fixing an artifact download failure that occurred when the workflow tried to download coverage data from the triggering On Push Qualification workflow.
Changes:
- Add
actions: readpermission to.github/workflows/on-push-comment.yamlto enable cross-workflow artifact downloads
dims
referenced
this pull request
in dims/aicr
Feb 20, 2026
Add three new validation steps to the H100 inference test: - Inference Gateway (#6): verify GatewayClass accepted and Gateway programmed with inference extension CRDs present - Accelerator & AI Service Metrics (#4/#5): verify DCGM Exporter metrics, Prometheus scraping, and custom metrics API availability - Secure Accelerator Access (#3): verify GPU access is DRA-mediated (no hostPath, no device plugin), with proper container security Also adds diagnostics for gateway, metrics, and DRA state on failure. Signed-off-by: Davanum Srinivas <[email protected]>
6 tasks
dims
referenced
this pull request
in dims/aicr
Feb 20, 2026
Add three new validation steps to the H100 inference test: - Inference Gateway (#6): verify GatewayClass accepted and Gateway programmed with inference extension CRDs present - Accelerator & AI Service Metrics (#4/#5): verify DCGM Exporter metrics, Prometheus scraping, and custom metrics API availability - Secure Accelerator Access (#3): verify GPU access is DRA-mediated (no hostPath, no device plugin), with proper container security Also adds diagnostics for gateway, metrics, and DRA state on failure. Signed-off-by: Davanum Srinivas <[email protected]>
This was referenced Feb 20, 2026
Contributor
|
This pull request has been automatically locked since it has been closed for 90 days with no further activity. Please open a new pull request for related changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add missing
actions: readpermission to thePost PR Commentworkflow so it can download artifacts from other workflow runs.Motivation / Context
The
workflow_runtriggered workflow needsactions: readpermission to download artifacts from the triggering workflow. Without this, thedownload-artifactaction fails with "Resource not accessible by integration".Error from run 21550864730:
Fixes: Follow-up to #5
Related: #3
Type of Change
Component(s) Affected
cmd/eidos,pkg/cli)cmd/eidosd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/).github/)Implementation Notes
Added
actions: readpermission to.github/workflows/on-push-comment.yaml. This is the minimum permission needed to download artifacts from other workflow runs.Testing
Risk Assessment
Rollout notes: N/A - single line permission addition
Checklist
make testwith-race)make lint)git commit -s) — DCO info