Skip to content

feat: add support for Akamai#517

Merged
lalitadithya merged 1 commit into
NVIDIA:mainfrom
lalitadithya:akamai
Apr 10, 2026
Merged

feat: add support for Akamai#517
lalitadithya merged 1 commit into
NVIDIA:mainfrom
lalitadithya:akamai

Conversation

@lalitadithya

@lalitadithya lalitadithya commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

Summary

Add support for Akamai CSP

Motivation / Context

Fixes:
Related:

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Build/CI/tooling

Component(s) Affected

  • CLI (cmd/aicr, pkg/cli)
  • API server (cmd/aicrd, pkg/api, pkg/server)
  • Recipe engine / data (pkg/recipe)
  • Bundlers (pkg/bundler, pkg/component/*)
  • Collectors / snapshotter (pkg/collector, pkg/snapshotter)
  • Validator (pkg/validator)
  • Core libraries (pkg/errors, pkg/k8s)
  • Docs/examples (docs/, examples/)
  • Other: ____________

Implementation Notes

Testing

# Commands run (prefer `make qualify` for non-trivial changes)
make qualify

Risk Assessment

  • Low — Isolated change, well-tested, easy to revert
  • Medium — Touches multiple components or has broader impact
  • High — Breaking change, affects critical paths, or complex rollout

Rollout notes:

Checklist

  • Tests pass locally (make test with -race)
  • Linter passes (make lint)
  • I did not skip/disable tests to make CI green
  • I added/updated tests for new functionality
  • I updated docs if user-facing behavior changed
  • Changes follow existing patterns in the codebase
  • Commits are cryptographically signed (git commit -S) — GPG signing info

@lalitadithya lalitadithya requested review from a team as code owners April 9, 2026 16:39
@copy-pr-bot

copy-pr-bot Bot commented Apr 9, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

github-actions Bot commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Welcome to AICR, @lalitadithya! Thanks for your first pull request.

Before review, please ensure:

  • All commits are signed off per the DCO
  • CI checks pass (tests, lint, security scan)
  • The PR description explains the why behind your changes

A maintainer will review this soon.

@mchmarny mchmarny enabled auto-merge (squash) April 9, 2026 23:04
@mchmarny mchmarny added this to the v0.12 milestone Apr 9, 2026
@mchmarny mchmarny disabled auto-merge April 9, 2026 23:04
@lalitadithya lalitadithya enabled auto-merge (squash) April 10, 2026 07:24
@lalitadithya lalitadithya merged commit 340452b into NVIDIA:main Apr 10, 2026
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants