Skip to content

fix(ci): expand GPU test triggers to cover collector, snapshotter, validator, and add run-gpu-tests label#514

Merged
xdu31 merged 2 commits into
NVIDIA:mainfrom
xdu31:gpu-test-trigger
Apr 9, 2026
Merged

fix(ci): expand GPU test triggers to cover collector, snapshotter, validator, and add run-gpu-tests label#514
xdu31 merged 2 commits into
NVIDIA:mainfrom
xdu31:gpu-test-trigger

Conversation

@xdu31

@xdu31 xdu31 commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Expand path triggers on all four GPU CI workflows to cover pkg/collector/, pkg/snapshotter/, pkg/validator/job/, pkg/validator/catalog/, pkg/defaults/timeouts.go, validators/conformance/, and .github/actions/gpu-snapshot-validate/
  • Add run-gpu-tests label trigger as a safety net for cases not covered by path filtering

Motivation

GPU CI tests only trigger on a narrow set of file paths. Recent PRs that affected GPU test behavior were not caught:

Closes #510

Test plan

  • make lint passes (no yamllint errors in workflow files)
  • Verify each workflow includes all 7 new paths in push.paths
  • Verify pull_request: types: [labeled] trigger is present on all 4 workflows
  • Verify job-level if: condition doesn't block schedule/push/dispatch triggers
  • Label a test PR with run-gpu-tests to confirm manual trigger works

@xdu31 xdu31 requested a review from a team as a code owner April 8, 2026 23:42
@github-actions

github-actions Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Welcome to AICR, @xdu31! Thanks for your first pull request.

Before review, please ensure:

  • All commits are signed off per the DCO
  • CI checks pass (tests, lint, security scan)
  • The PR description explains the why behind your changes

A maintainer will review this soon.

@yuanchen8911

yuanchen8911 commented Apr 9, 2026

Copy link
Copy Markdown
Contributor

Cross-Review Summary for PR #514

Reviewers: Claude Code, Codex, CodeRabbit + Integration Analysis
Rounds: 1 + Codex follow-up
Consensus reached: Yes — no confirmed defects

Confirmed Issues

None. The PR is correct as written.

Design Notes (not defects)

# Priority Note
1 Low Skipped-check noise — pull_request: types: [labeled] fires on any label event; the job-level if: skips unless the label is run-gpu-tests. Creates "skipped" check entries in PR UI but wastes no GPU runner time. Intentional trade-off for a manual override path.
2 Low No automatic rerun on synchronize — types: [labeled] only fires on label addition, not on new pushes to an already-labeled PR. Contributors must remove and re-add the label after pushing fixes. Possible follow-up enhancement.

Positive Observations

Cross-review by Claude Code + Codex + CodeRabbit

yuanchen8911
yuanchen8911 approved these changes Apr 9, 2026
View reviewed changes

@yuanchen8911 yuanchen8911 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@xdu31 xdu31 merged commit d30e235 into NVIDIA:main Apr 9, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuanchen8911 yuanchen8911 yuanchen8911 approved these changes

Assignees

No one assigned

Labels

area/ci size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expand GPU test triggers to cover collector, snapshotter, and validator changes

3 participants

@xdu31 @yuanchen8911 @mchmarny