fix(ci): query GPU snapshot by subtype name instead of index#509
Merged
mchmarny merged 1 commit intoApr 8, 2026
Merged
Conversation
PR NVIDIA#502 added a Phase 1 "hardware" subtype before the existing "smi" subtype in GPU measurements. The snapshot validation action used subtypes[0] to read gpu.model, which now hits "hardware" (no model field) instead of "smi", causing GPU model: null on all H100 runners. Fix: query by subtype name (select(.name == "smi")) instead of index. Signed-off-by: Yuan Chen <[email protected]>
mchmarny
approved these changes
Apr 8, 2026
yuanchen8911
added a commit
to yuanchen8911/aicr
that referenced
this pull request
Apr 8, 2026
Fix follow-up to NVIDIA#509 — the YAML field is 'subtype' not 'name': subtypes: - subtype: smi # correct field data: gpu.model: NVIDIA H100 NVL select(.name == "smi") returns empty; select(.subtype == "smi") works. Signed-off-by: Yuan Chen <[email protected]>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix GPU CI validation failure caused by #502 adding a
hardwaresubtype beforesmiin GPU measurements.Root Cause
PR #502 (
feat: wire NFDHardwareDetector into production snapshot pipeline) added a Phase 1hardwaresubtype that appears before the existingsmisubtype in the GPU measurement array:The snapshot validation action (
.github/actions/gpu-snapshot-validate/action.yml) usedsubtypes[0]to readgpu.model, which now hitshardwareinstead ofsmi→GPU model: null→ all H100 GPU tests fail.Confirmed on main: https://github.com/NVIDIA/aicr/actions/runs/24151637858
Fix
Query by subtype name instead of index:
Type of Change
Component(s) Affected
.github/actions/gpu-snapshot-validate)Checklist
git commit -S)