Skip to content

docs(adr): ADR-013 migrate artifact API domain to aicr.run#1492

Merged
mchmarny merged 3 commits into
mainfrom
docs/adr-013-aicr-run-domain
Jun 26, 2026
Merged

docs(adr): ADR-013 migrate artifact API domain to aicr.run#1492
mchmarny merged 3 commits into
mainfrom
docs/adr-013-aicr-run-domain

Conversation

@mchmarny

@mchmarny mchmarny commented Jun 26, 2026

Copy link
Copy Markdown
Member

Summary

Adds ADR-013 confirming the migration of the AICR artifact API domain from aicr.nvidia.com to aicr.run (pre-v1, host-only, with a transition window). Documentation only — no code change.

Motivation / Context

The artifact apiVersion group, K8s label/annotation keys, and in-toto/SLSA attestation URIs all stamp aicr.nvidia.com (~470 occurrences). Migrating to a vendor-neutral, maintainer-owned domain is a breaking change best landed before v1 while still on v1alpha1/v1beta1. This ADR records the drivers, scope (5 semantic roles), decision, and impact, reusing the dual-accept transition mechanism from ADR-011.

Fixes: N/A
Related: #1486 (epic), #1487, #1488, #1489, #1490, #1491

Type of Change

  • Documentation update

Component(s) Affected

  • Docs/examples (docs/, examples/)

Implementation Notes

  • Matches the existing ADR format (ADR-011/006): Problem, Non-Goals, Decision, Consequences, Adoption plan.
  • Host-only change; version segments (v1alpha1/v1beta1) and attestation URI paths are unchanged.
  • Calls out the two high-risk roles: published attestation predicate/build-type URIs and the deterministic bundle UUIDv5 namespace reset.
  • ADR-011 remains the governing apiVersion-evolution policy; its aicr.nvidia.com prose references are updated under Update docs and design-doc 011 for aicr.run domain migration #1491.

Testing

make qualify

Docs-only PR; anchor/link hygiene validated by CI (lychee) on docs/**.

Risk Assessment

  • Low — Documentation only, easy to revert. The behavioral change it describes is tracked separately under the epic.

Rollout notes: N/A — this PR adds a design record. The migration itself rolls out via #1487–#1491 with a dual-accept transition window.

Checklist

  • Tests pass locally (make test with -race)
  • Linter passes (make lint)
  • I did not skip/disable tests to make CI green
  • I added/updated tests for new functionality
  • I updated docs if user-facing behavior changed
  • Changes follow existing patterns in the codebase
  • Commits are cryptographically signed (git commit -S)

@mchmarny mchmarny requested a review from a team as a code owner June 26, 2026 11:44
@mchmarny mchmarny added area/docs theme/supply-chain SLSA, SBOM, Sigstore, and provenance verification labels Jun 26, 2026
@mchmarny mchmarny self-assigned this Jun 26, 2026
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Coverage data unavailable for this run. This can happen if the qualification workflow was cancelled or failed before generating coverage artifacts.

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

🌿 Preview your docs: https://nvidia-preview-docs-adr-013-aicr-run-domain.docs.buildwithfern.com/aicr

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds an ADR for migrating the AICR artifact API domain host from aicr.nvidia.com to aicr.run. It defines the host-only scope across apiVersion, labels, annotations, and attestation URIs, keeps version segments and URI paths unchanged, and documents the read/write transition behavior. It also notes deterministic UUIDv5 namespace seed changes, regeneration of signed artifacts and fixtures, and the adoption plan.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the ADR and the main change: migrating the artifact API domain to aicr.run.
Description check ✅ Passed The description matches the changeset and explains the ADR, scope, and rollout context.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/adr-013-aicr-run-domain

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]
coderabbitai Bot reviewed Jun 26, 2026
View reviewed changes

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/design/013-aicr-run-domain-migration.md`:
- Around line 61-64: The first fenced example is missing a language identifier,
so update the markdown fence in this section to include a tag such as yaml or
text. Keep the existing example content unchanged, and apply the fix to the
opening fenced block that shows the RecipeResult/apiVersion migration so
markdownlint and rendering stay consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 06f8d438-a397-4f84-a8b4-42b61b1cb0b0

📥 Commits

Reviewing files that changed from the base of the PR and between 6fc3444 and 52afc7c.

📒 Files selected for processing (1)
  • docs/design/013-aicr-run-domain-migration.md

Comment thread docs/design/013-aicr-run-domain-migration.md
@mchmarny mchmarny requested review from dims and lalitadithya June 26, 2026 11:49
dims
dims approved these changes Jun 26, 2026
View reviewed changes

@dims dims left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchmarny mchmarny merged commit 9b4a664 into main Jun 26, 2026
6 of 10 checks passed
@mchmarny mchmarny deleted the docs/adr-013-aicr-run-domain branch June 26, 2026 12:47
@mchmarny mchmarny mentioned this pull request Jun 26, 2026
Closed
1 task
@coderabbitai coderabbitai Bot mentioned this pull request Jun 26, 2026
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments
@dims dims dims approved these changes
@lalitadithya lalitadithya Awaiting requested review from lalitadithya

Assignees

@mchmarny mchmarny

Labels

area/docs size/M theme/supply-chain SLSA, SBOM, Sigstore, and provenance verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mchmarny @dims