Skip to content

docs(recipes): note b200-any-training retirement (#1053) in wildcard guide#1475

Merged
yuanchen8911 merged 1 commit into
NVIDIA:mainfrom
yuanchen8911:docs/b200-any-retirement-note
Jun 25, 2026
Merged

docs(recipes): note b200-any-training retirement (#1053) in wildcard guide#1475
yuanchen8911 merged 1 commit into
NVIDIA:mainfrom
yuanchen8911:docs/b200-any-retirement-note

Conversation

@yuanchen8911

@yuanchen8911 yuanchen8911 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Fix a stale sentence in the criteria-wildcard section of the recipe development guide: it credited only the gb200-any-training.yaml retirement (#1052) but b200-any-training.yaml was likewise retired (#1053). Both -any-training wildcards are already gone on main.

Motivation / Context

On main, recipes/overlays/b200-any.yaml and gb200-any.yaml are the live deployment-floor wildcards — the intent-scoped *-any-training.yaml variants that previously carried cross-service NCCL thresholds were both retired. The integrator guide still named only the GB200 retirement, which risks a recipe author copying the retired B200 cross-service NCCL-threshold pattern back in. This names both.

Fixes: N/A
Related: #1052, #1053, #1004

Type of Change

  • Documentation update

Component(s) Affected

  • Docs/examples (docs/, examples/)

Implementation Notes

One-line edit to docs/integrator/recipe-development.md. Wording mirrors the contributor-side guidance. The anchor link target (recipe.md#criteria-wildcard-overlays) is unchanged and verified present.

Testing

# Doc-only change — no code paths affected; full `make qualify` not run.
# Verified: both -any-training overlays are absent on main (b200-any.yaml /
# gb200-any.yaml present), and the referenced anchor heading exists.

Doc-only: tests, e2e, and Go lint cannot regress from this change. CI lychee link-check covers the touched docs/** file.

Risk Assessment

  • Low — Isolated doc wording fix, easy to revert

Rollout notes: N/A

Checklist

  • I updated docs if user-facing behavior changed
  • Changes follow existing patterns in the codebase
  • Commits are cryptographically signed (git commit -S)

@yuanchen8911 yuanchen8911 requested a review from a team as a code owner June 25, 2026 15:51
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

🌿 Preview your docs: https://nvidia-preview-docs-b200-any-retirement-note.docs.buildwithfern.com/aicr

@yuanchen8911 yuanchen8911 requested a review from mchmarny June 25, 2026 15:53
@coderabbitai

coderabbitai Bot commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 4653f776-7fd9-48bf-a5b0-acfc73003e7b

📥 Commits

Reviewing files that changed from the base of the PR and between 91ce515 and 3e66fd4.

📒 Files selected for processing (1)
  • docs/integrator/recipe-development.md
📝 Walkthrough

Walkthrough

docs/integrator/recipe-development.md updates the wildcard-criteria overlay guidance to stress uniformity requirements, explicitly excludes NCCL performance thresholds from cross-service wildcard overlays, and revises the historical references to include both gb200-any-training and b200-any-training with their PR references.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately reflects the doc update about the retired b200-any-training overlay.
Description check ✅ Passed The description is directly related to the documentation fix and explains the stale retirement reference.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@yuanchen8911 yuanchen8911 force-pushed the docs/b200-any-retirement-note branch from 91ce515 to a2a6c2d Compare June 25, 2026 16:02
mchmarny
mchmarny approved these changes Jun 25, 2026
View reviewed changes

@mchmarny mchmarny left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc-only one-line fix; correctly names both -any-training wildcard retirements. Verified against main: only b200-any.yaml/gb200-any.yaml remain (no *-any-training overlays), b200-any-training.yaml was deleted in PR #1053 (commit bbf81769), and the recipe.md#criteria-wildcard-overlays anchor exists. Genuine improvement over the prior text, which named only the GB200 retirement and risked a reader copying the B200 cross-service NCCL pattern back in.

Non-blocking nit: slight reference-type asymmetry — #1052 is the umbrella issue (GB200's implementing PR was actually #1068), while #1053 is a PR. Both auto-link and are relevant, and the #1052 reference predates this PR, so no change needed.

LGTM.

@yuanchen8911 yuanchen8911 enabled auto-merge (squash) June 25, 2026 19:28
@yuanchen8911
docs(recipes): note b200-any-training retirement (NVIDIA#1053) in wil…
3e66fd4 
…dcard guide

recipe-development.md's criteria-wildcard section credited only the
gb200-any-training.yaml retirement (NVIDIA#1052), but b200-any-training.yaml
was likewise retired in NVIDIA#1053 (both -any-training wildcards are gone on
main; b200-any.yaml / gb200-any.yaml are the live deployment-floor
overlays). Name both so recipe authors don't reintroduce the retired
B200 cross-service NCCL-threshold pattern.

Doc-only.
@yuanchen8911 yuanchen8911 force-pushed the docs/b200-any-retirement-note branch from a2a6c2d to 3e66fd4 Compare June 25, 2026 19:32
@yuanchen8911 yuanchen8911 merged commit 6fc3444 into NVIDIA:main Jun 25, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchmarny mchmarny mchmarny approved these changes
@njhensley njhensley njhensley approved these changes

Assignees

@yuanchen8911 yuanchen8911

Labels

area/docs size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuanchen8911 @mchmarny @njhensley