fix(uat): bind Prometheus PVC to cluster default StorageClass#1455
Merged
njhensley merged 2 commits intoJun 24, 2026
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe H100 AWS UAT training config changes Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mchmarny
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the AWS UAT config so the Prometheus PVC binds to the cluster's default StorageClass instead of a hardcoded
gp3name that doesn't exist on an aicr-bundle-deployed EKS cluster.Motivation / Context
On the AWS UAT cluster, deployment readiness checks blocked indefinitely: the Prometheus StatefulSet was never created. The prometheus-operator was healthy but refused to reconcile with:
spec.bundle.scheduling.storageClasswas pinned to a literalgp3. An aicr-bundle-deployed EKS cluster has no StorageClass by that name — theaws-ebs-csi-drivercomponent provisions a gp3-backed default namedebs-csi-default-sc(annotatedis-default-class=true). A class literally namedgp3only exists on clusters using the AWS managed EBS CSI addon. The stale comment ("Matches the UAT cluster") was incorrect.Fixes: N/A
Related: N/A
Type of Change
Component(s) Affected
Implementation Notes
Set
storageClass: "". The injection path only writes a value when non-empty (pkg/cli/bundle.go→pkg/bundler/bundler.go), so an empty value is a true no-op. The EKS overlay (recipes/overlays/eks.yaml) already defines the PrometheusvolumeClaimTemplate(50Gi, RWO,emptyDir: null) without astorageClassName, so the PVC binds to the cluster default SC. Persistent storage is preserved (not dropped to emptyDir) and the config no longer depends on how EBS CSI was installed.GCP UAT config is unchanged — GKE genuinely ships a class named
premium-rwo.Testing
Risk Assessment
Rollout notes: N/A — test harness config only; no production code path.
Checklist
make testwith-race)make lint)git commit -S)