fix(recipes): pin nvidia-dra-driver-gpu to 0.4.1-rc.1 for strict-YAML fix#1341
Merged
Merged
Conversation
Contributor
Recipe evidence check
Affected leaf overlays: 63
How to refresh evidenceRun on a cluster matching the recipe's aicr snapshot -o snapshot.yaml
aicr validate \
-r recipes/overlays/<slug>.yaml \
-s snapshot.yaml \
--emit-attestation ./out \
--push ghcr.io/<your-fork>/aicr-evidence
cp ./out/pointer.yaml recipes/evidence/<slug>.yamlThis gate is warning-only and never blocks merge. See ADR-007 for the trust model. |
📝 WalkthroughWalkthroughThis PR updates the Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
yuanchen8911
force-pushed
the
fix/dra-pin-0.4.1-rc.1
branch
from
c20b58c to
823bdd9
Compare
Member
|
This also closes this one too, right? 1289 |
mchmarny
approved these changes
Jun 12, 2026
… fix The 0.4.0 chart (oci://registry.k8s.io/dra-driver-nvidia/charts) emits a duplicate nvidia-dra-driver-gpu-component pod-template label key for both the controller Deployment and the kubelet-plugin DaemonSet when rendered with AICR's values. Plain Helm tolerates the duplicate, but strict-YAML consumers that post-process the rendered manifests (Argo CD, Flux, kustomize, yq) fail the install with 'mapping key already defined'. Pin to the upstream 0.4.1-rc.1 release, which collapses the label to a single key. Verified with the exact values AICR's Flux deployer injects: kustomize build fails on 0.4.0 and passes on 0.4.1-rc.1. This RC pin is temporary; bump to the 0.4.1 GA release once it lands (scheduled week of 2026-06-29). Refs: kubernetes-sigs/dra-driver-nvidia-gpu#1184
yuanchen8911
force-pushed
the
fix/dra-pin-0.4.1-rc.1
branch
from
ae2eb7f to
520fa96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin
nvidia-dra-driver-gpufrom0.4.0to0.4.1-rc.1(sameoci://registry.k8s.io/dra-driver-nvidia/chartschart) to fix a duplicate pod-template label key that produces invalid YAML for strict consumers.Motivation / Context
The
0.4.0chart emits thenvidia-dra-driver-gpu-componentlabel twice in the pod template (metadata.labels) for both the controller Deployment and the kubelet-plugin DaemonSet when rendered with AICR's values. Plain Helm tolerates the duplicate, but strict-YAML consumers that post-process the rendered manifests (Argo CD, Flux, kustomize, yq) fail the install withmapping key "nvidia-dra-driver-gpu-component" already defined. This breaks GitOps deployments — notably Flux reconciliation.Upstream
0.4.1-rc.1collapses the label to a single key. This is the RC cut specifically for AICR to pin to; the pin is temporary and will be bumped to the0.4.1GA release once it lands (scheduled week of 2026-06-29).Fixes: 1289
Related: #1285 (the migration to registry.k8s.io v0.4.0 that introduced the regression), (upstream kubernetes-sigs/dra-driver-nvidia-gpu#1184)
Type of Change
Component(s) Affected
pkg/recipe)docs/,examples/)Implementation Notes
recipes/registry.yaml(defaultVersion) andrecipes/overlays/base.yaml(version), with an inlineTEMPORARYcomment at each explaining the RC rationale and the GA follow-up.docs/user/container-images.mdviamake bom-docs(chart version + image tag updated tov0.4.1-rc.1).Testing
End-to-end Flux-path verification using the exact
spec.valuesAICR's Flux deployer injects (controller + kubeletPlugin nodeSelector/tolerations), rendering the OCI chart and runningkustomize build:0.4.0:kustomize buildFAILS —mapping key "nvidia-dra-driver-gpu-component" already defined0.4.1-rc.1:kustomize buildPASSES; label appears once per pod templateRisk Assessment
Rollout notes: Temporary RC pin. Follow-up PR will bump to
0.4.1GA when released (~week of 2026-06-29).Checklist
make testwith-race)make lint)git commit -S)