refactor(recipe): move embedded data to recipes/ at repo root#114
Merged
Conversation
- Add recipes/ with data.go (go:embed), overlays/, components/, registry.yaml - Point pkg/recipe at recipes.GetEmbeddedFS() with empty prefix - Update provider path handling for empty prefix; fix recipe-overlays and tools/describe paths - Exclude recipes/components/*/manifests/ from yamllint (Helm templates)
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
Signed-off-by: Yuan Chen <[email protected]>
lockwobr
force-pushed
the
recipe-root
branch
from
4e51b77 to
1619064
Compare
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
lockwobr
force-pushed
the
recipe-root
branch
from
79e93f5 to
f335a27
Compare
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
lockwobr
force-pushed
the
recipe-root
branch
from
806c230 to
0b669c6
Compare
Contributor
|
This pull request has been automatically locked since it has been closed for 90 days with no further activity. Please open a new pull request for related changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation / Context
To make it easier for people to find the recipes and contribute, moved them to the root of the project. To make work in embed, need to make a package out of it and update the recipe package to use this new package.
Fixes:
Related:
Type of Change
Component(s) Affected
cmd/eidos,pkg/cli)cmd/eidosd,pkg/api,pkg/server)pkg/recipe)pkg/bundler,pkg/component/*)pkg/collector,pkg/snapshotter)pkg/validator)pkg/errors,pkg/k8s)docs/,examples/)Implementation Notes
Testing
# Commands run (prefer `make qualify` for non-trivial changes) make qualifyRisk Assessment
Rollout notes:
Checklist
make testwith-race)make lint)git commit -s) — DCO info