fix: add eidos binary to validator image#112
Closed
yuanchen8911 wants to merge 11 commits into
Closed
Conversation
The validator Dockerfile only built test binaries but not the main eidos binary. Agent jobs (validate, snapshot) expect the binary at /ko-app/eidos, causing "no such file or directory" errors. Build the eidos binary at /ko-app/eidos and update CMD to match. Signed-off-by: Yuan Chen <[email protected]>
Member
|
@iamkhaledh @xdu31 PTAL |
1 task
Contributor
|
The validator image only runs go test in phase Jobs, it never invokes /ko-app/eidos. |
Contributor
|
This pull request has been automatically locked since it has been closed for 90 days with no further activity. Please open a new pull request for related changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.test) but not the maineidosbinarypkg/k8s/agent/job.go:118) use/ko-app/eidosas the container command, which doesn't exist in the validator imageeidos validateandeidos snapshotagent-based commands (affected: v0.5.7 through v0.5.16)go build -o /ko-app/eidos ./cmd/eidostoDockerfile.validatorand updatesCMDto matchTest plan
docker build -f Dockerfile.validator -t eidos-validator:test .docker run --rm eidos-validator:test ls -la /ko-app/eidoseidos validateagainst a cluster with the new image