fix: rename skyhook CR to remove training suffix#111
Merged
mchmarny merged 4 commits intoFeb 12, 2026
Conversation
ayuskauskas
previously approved these changes
Feb 12, 2026
ayuskauskas
left a comment
ayuskauskas
left a comment
Contributor
There was a problem hiding this comment.
Lets merge this in before my PR #96 as that will cleanup all the syhook parts anyway
PR #109 renamed the manifest file from h100-eks-ubuntu-training.yaml to h100-eks-ubuntu.yaml but missed updating the Skyhook CR metadata.name inside the file. This caused inference deployments to create pods with "training" in their name. Signed-off-by: Yuan Chen <[email protected]>
yuanchen8911
force-pushed
the
fix/skyhook-cr-name-training-suffix
branch
from
4ce5338 to
de43393
Compare
dims
approved these changes
Feb 12, 2026
3 tasks
lockwobr
pushed a commit
that referenced
this pull request
Feb 12, 2026
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
lockwobr
pushed a commit
that referenced
this pull request
Feb 12, 2026
Signed-off-by: Yuan Chen <[email protected]> Co-authored-by: Mark Chmarny <[email protected]>
Contributor
|
This pull request has been automatically locked since it has been closed for 90 days with no further activity. Please open a new pull request for related changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h100-eks-ubuntu-training.yamltoh100-eks-ubuntu.yamlbut missed updating the Skyhook CRmetadata.nameinside the fileh100-eks-ubuntu-training-fix-mac-address-policy-...)h100-eks-ubuntu-trainingtoh100-eks-ubuntuTest plan