refactor: rename skyhook customization manifest to remove training suffix#109
Merged
mchmarny merged 3 commits intoFeb 12, 2026
Merged
Conversation
…ffix Rename h100-eks-ubuntu-training.yaml to h100-eks-ubuntu.yaml since the manifest contains H100+EKS+Ubuntu node customizations (hugepages, containerd limits, sysctl tuning) that apply to both training and inference workloads. Update references in both overlays. Signed-off-by: Yuan Chen <[email protected]>
2 tasks
yuanchen8911
referenced
this pull request
in yuanchen8911/aicr-old
Feb 12, 2026
PR #109 renamed the manifest file from h100-eks-ubuntu-training.yaml to h100-eks-ubuntu.yaml but missed updating the Skyhook CR metadata.name inside the file. This caused inference deployments to create pods with "training" in their name. Signed-off-by: Yuan Chen <[email protected]>
Contributor
|
This pull request has been automatically locked since it has been closed for 90 days with no further activity. Please open a new pull request for related changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
h100-eks-ubuntu-training.yaml→h100-eks-ubuntu.yamlin skyhook-customizations manifestsh100-eks-ubuntu-trainingandh100-eks-ubuntu-inferenceoverlaysTest plan
go test -race ./pkg/recipe/...— passes🤖 Generated with Claude Code