Bug Description
Every aicr bundle with --intent training emits two warnings
regardless of any other flag, including --attest:
⚠ Warning: nodewright-customizations is enabled but --workload-selector is not set.
This may cause nodewright to evict running training jobs.
Consider setting --workload-selector to prevent eviction.
⚠ Warning: nodewright-customizations is enabled but --accelerated-node-selector
is not set. Without this selector, the customization will run on all nodes.
Consider setting --accelerated-node-selector to target specific nodes.
Universal-fire dilutes signal — real warnings get buried in boilerplate.
Impact
Low — noise-level UX nit.
Component
Bundlers (validations) + CLI
Regression?
Unknown — warnings appear whenever --intent training is set and the
selectors are unset, which is the common case for first-time users.
Reproduction
Any aicr bundle invocation with --intent training that doesn't also
pass both --workload-selector and --accelerated-node-selector.
Where
pkg/bundler/validations/checks.go — CheckWorkloadSelectorMissing and
CheckAcceleratedSelectorMissing. Existing tests in
pkg/bundler/validations/checks_test.go:67-213.
Proposed Fix
Pick one:
a. Make one of the selectors a sensible default (e.g.,
--workload-selector defaulting to a broadly-used label like
accelerator=nvidia-h100 or whatever the common case is).
b. Gate the warning behind "actually missing AND training-sensitive"
conditions instead of "intent=training and unset".
c. Suppress once the user sets --best-effort or an equivalent
"I know" flag.
Scope
Small. Not stable-blocking. Gate on whichever design path the team
prefers; tests already exist for the current behavior and can be
extended with cases for the new suppression/default path.
Bug Description
Every
aicr bundlewith--intent trainingemits two warningsregardless of any other flag, including
--attest:Universal-fire dilutes signal — real warnings get buried in boilerplate.
Impact
Low — noise-level UX nit.
Component
Bundlers (validations) + CLI
Regression?
Unknown — warnings appear whenever
--intent trainingis set and theselectors are unset, which is the common case for first-time users.
Reproduction
Any
aicr bundleinvocation with--intent trainingthat doesn't alsopass both
--workload-selectorand--accelerated-node-selector.Where
pkg/bundler/validations/checks.go—CheckWorkloadSelectorMissingandCheckAcceleratedSelectorMissing. Existing tests inpkg/bundler/validations/checks_test.go:67-213.Proposed Fix
Pick one:
a. Make one of the selectors a sensible default (e.g.,
--workload-selectordefaulting to a broadly-used label likeaccelerator=nvidia-h100or whatever the common case is).b. Gate the warning behind "actually missing AND training-sensitive"
conditions instead of "intent=training and unset".
c. Suppress once the user sets
--best-effortor an equivalent"I know" flag.
Scope
Small. Not stable-blocking. Gate on whichever design path the team
prefers; tests already exist for the current behavior and can be
extended with cases for the new suppression/default path.