Context
The upstream Skyhook project has been renamed:
NVIDIA/skyhook → NVIDIA/nodewright ("A Kubernetes Operator to manage Node OS customizations.")
NVIDIA/skyhook-packages → NVIDIA/nodewright-packages
GitHub auto-redirects the old names, so current URLs and chart references still resolve — nothing is broken today. But the canonical names are now nodewright / nodewright-packages, and our repo carries the old name pervasively.
Raised by @lockwobr as an inline nit on PR #625: #625 (comment)
Scope
git grep -i skyhook on origin/main returns 611 hits across 92 files, including (non-exhaustive):
- Documentation (~18 files):
docs/integrator/components/skyhook.md, references in user/contributor docs, CHANGELOG.md, ROADMAP.md, demos.
- Recipe config and components:
recipes/registry.yaml (entries skyhook-operator, skyhook-customizations), directories recipes/components/skyhook/, recipes/components/skyhook-customizations/, chart values.
- Go source:
pkg/bundler/, pkg/recipe/, pkg/component/, pkg/cli/ — constants, component paths, handler logic, tests.
- Helm templates:
pkg/bundler/deployer/helm/templates/deploy.sh.tmpl, undeploy.sh.tmpl.
- Examples and tests:
examples/recipes/*.yaml, bundler/recipe test fixtures, KWOK scripts.
- API contract:
api/aicr/v1/server.yaml (references in docs/examples).
Considerations for the rename
- Component directory rename (
recipes/components/skyhook{,-customizations}/ → recipes/components/nodewright{,-customizations}/) cascades into registry entries, recipe componentRefs in overlays/mixins, bundler path resolution, and any hardcoded constants in Go.
- Chart values keys: any Helm values referencing
skyhook-prefixed keys need coordinated rename, including override paths exposed via --set flags.
- Backwards compatibility: existing user recipes reference the component by current name. Decide whether to support both names during a deprecation window or require users to update.
- Commit trail / blame: consider whether to do this as one atomic commit or split by concern (docs, recipes, Go, templates).
Acceptance criteria
- All repo references to
Skyhook / skyhook (project-level, not literal Linux syscalls or unrelated) updated to Nodewright / nodewright.
- Component directories renamed with all downstream references updated.
- Chart values keys renamed where appropriate.
- Decision documented on backwards-compat for existing user recipes.
make qualify passes end-to-end.
- Skyhook component doc page renamed/updated to reflect the new project name; redirect or stub left if needed for inbound links.
Priority
Filed as P2 — the repo's priority labels are P0/P1/P2 (no P3). Feel free to downgrade if a lower-priority label is added.
Context
The upstream Skyhook project has been renamed:
NVIDIA/skyhook→NVIDIA/nodewright("A Kubernetes Operator to manage Node OS customizations.")NVIDIA/skyhook-packages→NVIDIA/nodewright-packagesGitHub auto-redirects the old names, so current URLs and chart references still resolve — nothing is broken today. But the canonical names are now
nodewright/nodewright-packages, and our repo carries the old name pervasively.Raised by @lockwobr as an inline nit on PR #625: #625 (comment)
Scope
git grep -i skyhookonorigin/mainreturns 611 hits across 92 files, including (non-exhaustive):docs/integrator/components/skyhook.md, references in user/contributor docs,CHANGELOG.md,ROADMAP.md, demos.recipes/registry.yaml(entriesskyhook-operator,skyhook-customizations), directoriesrecipes/components/skyhook/,recipes/components/skyhook-customizations/, chart values.pkg/bundler/,pkg/recipe/,pkg/component/,pkg/cli/— constants, component paths, handler logic, tests.pkg/bundler/deployer/helm/templates/deploy.sh.tmpl,undeploy.sh.tmpl.examples/recipes/*.yaml, bundler/recipe test fixtures, KWOK scripts.api/aicr/v1/server.yaml(references in docs/examples).Considerations for the rename
recipes/components/skyhook{,-customizations}/→recipes/components/nodewright{,-customizations}/) cascades into registry entries, recipecomponentRefsin overlays/mixins, bundler path resolution, and any hardcoded constants in Go.skyhook-prefixed keys need coordinated rename, including override paths exposed via--setflags.Acceptance criteria
Skyhook/skyhook(project-level, not literal Linux syscalls or unrelated) updated toNodewright/nodewright.make qualifypasses end-to-end.Priority
Filed as P2 — the repo's priority labels are P0/P1/P2 (no P3). Feel free to downgrade if a lower-priority label is added.