Skip to content

Transition window: dual-accept aicr.nvidia.com and aicr.run apiVersion on read #1489

Description

@mchmarny

Part of #1486. Depends on the centralization issue; can land alongside the flip.

Implement the transition window so old artifacts keep working for one release.

  • pkg/header.IsSupportedAPIVersion accepts both aicr.nvidia.com/v1alpha1 and aicr.run/v1alpha1 (and the v1beta1 build spec equivalents)
  • Artifact decoders (pkg/build/spec.go, recipe/snapshot/config loaders) accept either group on read
  • Emit a single deprecation slog.Warn when the old group is encountered
  • Always write the new aicr.run group

Follow the dual-accept pattern documented in docs/design/011-artifact-apiversion-policy.md.

Acceptance criteria

  • Old-group artifact reads successfully + logs one deprecation warning
  • All writes emit aicr.run
  • Table-driven tests cover old, new, and empty apiVersion
  • make qualify green

Metadata

Metadata

Assignees

Type

Fields

No fields configured for Task.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions