Summary

pkg/mirror/discover.go:extractManifestImages reads manifests via recipe.GetManifestContentWithContext(ctx, nil, mPath) — the nil falls back to the package-level embedded provider. The sibling call in Discover (for component values) uses the recipe-bound provider via rec.GetValuesForComponentWithContext(gctx, ...).

So today, aicr mirror against a --data overlay reads component values from the overlay but manifests from embedded/global. This is inconsistent.

Context

Flagged by @yuanchen8911 in PR #1121 review. Pre-existing — the prior recipe.GetManifestContent(mPath) (before #1121) was also unconditionally global. Out of scope for #1109's interface-cancellation work, but worth fixing for --data consistency in mirror.

Acceptance

• extractManifestImages accepts the recipe's DataProvider (e.g., from rec.DataProvider()) and passes it to recipe.GetManifestContentWithContext instead of nil.
• aicr mirror --data <dir> reads overlay-provided manifests when the overlay shadows an embedded manifest path.
• Test: an overlay with a custom manifest file under components/<name>/manifests/ is honored by aicr mirror.

Related

• feat(recipe): add context.Context to DataProvider interface for cancellable I/O #1109 (where the inconsistency was flagged)
• feat(recipe): context-aware DataProvider interface #1121 (the PR landing feat(recipe): add context.Context to DataProvider interface for cancellable I/O #1109)