Summary

Tracking epic for follow-up work introduced by #1072 (the top-level github.com/NVIDIA/aicr facade). Each child is independently reviewable and mergeable.

Status: ✅ closed — all four children merged.

Motivation

PR #1072 ships the aicr.Client facade defined by #1071 and lands the per-Builder DataProvider isolation that #986 was scoped to provide. The facade is functional, but to actually deliver the architectural payoff and honor its documented semver contract, several deferred items need to land.

Without these:

• The codebase carries three independent wiring paths for DataProvider → Builder → Bundler → Validator (CLI, REST, facade).
• The facade's "Public (stable)" contract identity-aliases types from packages marked Internal / "Public (evolving)" in docs/integrator/public-api.md, undermining the semver promise.
• The cross-Client safety guard [Feature]: Stable embeddable Go library surface for in-process recipe resolution #1071 motivates only protects facade callers; direct pkg/recipe.Builder users (today: pkg/api/server.go) remain exposed.
• Test-only helpers leaked onto pkg/recipe's public surface.

Final status

Closed: 2026-05-29

Children

Adjacent work landed alongside the epic

These weren't original children but ship in the same area and were folded into the rollout:

• refactor(recipe,validator): per-DataProvider sources + criteria-registry de-globalization #1107 (PR 1 of 2 for feat(cli,api): migrate CLI and REST server to consume aicr.Client #1077) — per-DataProvider sources + criteria-registry de-globalization (foundation for feat(cli,api): migrate CLI and REST server to consume aicr.Client #1077)
• refactor(aicr): move public facade from module root to pkg/aicr/ #1112 — move public facade from module root to pkg/aicr/ (cleaner project layout)
• feat(aicr): wrap facade alias types as facade-owned structs #1111 — also moved the facade from pkg/aicr/ to pkg/client/v1/ (versioned SDK location, matches pkg/api/validator/v1 pattern) in the same PR as the alias wrapping
• refactor(validator): move v1 schema from pkg/api/validator/v1 to pkg/validator/v1 #1117 — moved validator schema from pkg/api/validator/v1 to pkg/validator/v1 (symmetric with pkg/client/v1; pkg/api/ is now consistently HTTP-handler-only)

Acceptance — all met

• ✅ All four children merged.
• ✅ docs/integrator/public-api.md matches the actual exported surface (no Internal types identity-aliased into the stable facade tier — see "Facade type ownership" section).
• ✅ pkg/api/server.go and pkg/cli/ no longer construct recipe.Builder / bundler.Bundler directly (migrated by feat(cli,api): consume aicr.Client facade (#1077) #1108).
• ✅ make qualify clean throughout.

Follow-up work (tracked separately, post-epic)

These surfaced during the epic and were explicitly scoped out to keep PRs focused. Each has its own tracking issue:

Out of scope (separate work)

• OCI recipe sources (placeholder in aicr.go returning ErrCodeUnavailable)
• Pinned recipe references (RecipeRequest.PinnedName / PinnedVersion)

Related

• [Feature]: Stable embeddable Go library surface for in-process recipe resolution #1071 — the feature request
• feat(aicr): top-level Go library facade for in-process consumers #1072 — the implementing PR
• feat(cli,api): migrate CLI and REST server to consume aicr.Client #1104 — closed; superseded by refactor(recipe,validator): per-DataProvider sources + criteria-registry de-globalization #1107 + feat(cli,api): consume aicr.Client facade (#1077) #1108
• feat(recipe): add context.Context to DataProvider interface for cancellable I/O #1109 — context-aware DataProvider (adjacent, surfaced during refactor(recipe,validator): per-DataProvider sources + criteria-registry de-globalization #1107 review)
• refactor(aicr): move public facade from module root to pkg/aicr/ #1112 — facade move to pkg/aicr/ (later moved to pkg/client/v1/ in feat(aicr): wrap facade alias types as facade-owned structs #1111)
• chore(recipe): remove back-compat shims introduced by #1107 #1114 — back-compat shim removal (post-epic cleanup)
• feat(client/v1): wrap remaining facade alias types (Recipe, AllowLists, Criteria, CriteriaRegistry) #1115 — wrap remaining facade alias types (post-epic cleanup)
• refactor(validator): move v1 schema from pkg/api/validator/v1 to pkg/validator/v1 #1117 — validator schema move to pkg/validator/v1
• [Epic]: Library-readiness hardening for in-process Go consumers #983 (closed) — library-readiness hardening epic that preceded this work
• feat(recipe): deprecate SetDataProvider / GetDataProvider globals #987 (closed) — SetDataProvider Stage 1 deprecation marker