Skip to content

Conversation

@chzblych
Copy link
Collaborator

@chzblych chzblych commented Dec 11, 2025

Summary by CodeRabbit

  • Chores
    • Updated package dependencies to ensure compatibility and stability.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chzblych chzblych requested a review from a team as a code owner December 11, 2025 09:14
@chzblych
Copy link
Collaborator Author

/bot run --disable-fail-fast

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

📝 Walkthrough

Walkthrough

Updated Python package constraints for FastAPI from version <=0.117.1 to >=0.120.1,<=0.121.3, and added Starlette as an explicit dependency with version >=0.49.1.

Changes

Cohort / File(s) Change Summary
Dependency Version Updates
requirements.txt
Tightened FastAPI version range to 0.120.1–0.121.3; added explicit Starlette dependency >=0.49.1

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Verify that FastAPI 0.120.1–0.121.3 range is compatible with existing codebase functionality
  • Confirm Starlette >=0.49.1 does not introduce breaking changes or conflicts with the new FastAPI versions
  • Check if any code changes are needed to accommodate the updated dependencies

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete. It contains only the template structure and bot help documentation, with no actual content in the required Description, Test Coverage, or checklist sections beyond a checked box. Add a clear description of why the dependencies were upgraded and what test coverage validates these changes. Complete the PR checklist by providing specific information for each applicable item.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: upgrading Starlette and FastAPI dependencies. It follows the required format with [None][chore] and is directly related to the requirements.txt modifications shown in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6624cc2 and 9cc58a5.

📒 Files selected for processing (1)
  • requirements.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
requirements.txt (1)

47-48: Verify version compatibility and request context on the tight FastAPI constraint.

FastAPI 0.120 adds support for Starlette 0.49, which aligns with this change. However, the FastAPI constraint >=0.120.1,<=0.121.3 is very tight—it allows only 3 minor versions. This is unusually restrictive and may hinder future security updates or patch releases.

Additionally, FastAPI depends on Pydantic and Starlette, so explicitly pinning Starlette could create transitive dependency conflicts. Please verify:

  1. Why the tight version range? The constraint allows only FastAPI 0.120.1, 0.120.2, 0.121.0, 0.121.1, 0.121.2, and 0.121.3. Is there a specific reason to exclude later patch versions or 0.120.0?
  2. Compatibility verification: Confirm that FastAPI 0.120.1–0.121.3 are compatible with Starlette >=0.49.1 without deprecation warnings.
  3. Transitive dependency safety: Ensure pip's dependency resolver won't surface conflicts when resolving the requirements.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27833 [ run ] triggered by Bot. Commit: 9cc58a5

@chzblych chzblych enabled auto-merge (squash) December 11, 2025 09:23
@tensorrt-cicd
Copy link
Collaborator

PR_Github #27833 [ run ] completed with state SUCCESS. Commit: 9cc58a5
/LLM/release-1.1/L0_MergeRequest_PR pipeline #569 completed with status: 'SUCCESS'

@chzblych chzblych merged commit 48b7b5d into NVIDIA:release/1.1 Dec 11, 2025
8 of 9 checks passed
@chzblych chzblych deleted the release/1.1 branch December 11, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants