Skip to content

[TRTLLM-9132][infra] Update to ignore failure for release check and building images#9871

Merged
EmmaQiaoCh merged 29 commits into
NVIDIA:mainfrom
EmmaQiaoCh:emma/warn_nspect_build_failure
Apr 17, 2026
Merged

[TRTLLM-9132][infra] Update to ignore failure for release check and building images#9871
EmmaQiaoCh merged 29 commits into
NVIDIA:mainfrom
EmmaQiaoCh:emma/warn_nspect_build_failure

Conversation

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Dec 10, 2025

Summary by CodeRabbit

  • Chores
    • Improved error handling consistency in build and merge workflows by standardizing failure reporting across multiple pipeline scenarios.
    • Enhanced error reporting clarity for release checks and Docker image build processes with more generic, consistent error messages.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@EmmaQiaoCh EmmaQiaoCh requested review from a team as code owners December 10, 2025 09:39
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Dec 10, 2025

📝 Walkthrough

Walkthrough

Modifications to error handling in Jenkins pipeline script to consistently report failures as UNSTABLE status instead of mixed SUCCESS/FAILURE outcomes. Changes affect three error handling paths: release check validation, post-merge test rerun results, and Docker image build forking logic.

Changes

Cohort / File(s) Summary
Error handling standardization
jenkins/L0_MergeRequest.groovy
Modified three error handling paths to consistently report failures as UNSTABLE: (1) Release check exceptions now always report UNSTABLE with generic error message instead of conditional SUCCESS with failure; (2) Official post-merge job rerun failures changed from FAILURE to UNSTABLE; (3) Build-Docker-Images branch determination and downstream launch wrapped in try-catch with UNSTABLE error reporting via catchError, while InterruptedException remains rethrown

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • Note that understanding Jenkins failure semantics (SUCCESS vs FAILURE vs UNSTABLE) is essential for verifying the correctness of each change
  • Review focus areas: verify that UNSTABLE is the appropriate status choice for each error scenario and that exception handling logic (particularly InterruptedException rethrow behavior) is preserved correctly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description template is present but critical sections (Description and Test Coverage) are empty; only the PR Checklist checkbox is marked. Fill in the Description section explaining what issue is being addressed and the solution. Provide Test Coverage details showing what tests safeguard these changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: updating Jenkins scripts to handle failures from release checks and Docker image builds as non-blocking (UNSTABLE instead of FAILURE).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #27688 [ run ] triggered by Bot. Commit: 486ecbf

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #27688 [ run ] completed with state SUCCESS. Commit: 486ecbf
/LLM/main/L0_MergeRequest_PR pipeline #21136 completed with status: 'SUCCESS'

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot run --post-merge

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #27810 [ run ] triggered by Bot. Commit: 486ecbf

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #27810 [ run ] completed with state SUCCESS. Commit: 486ecbf
/LLM/main/L0_MergeRequest_PR pipeline #21226 completed with status: 'FAILURE'

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot run --post-merge --extra-stage "Build-Docker-Images, Release Check" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #28366 [ run ] triggered by Bot. Commit: e1e33e1

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #28366 [ run ] completed with state SUCCESS. Commit: e1e33e1
/LLM/main/L0_MergeRequest_PR pipeline #21703 completed with status: 'SUCCESS'

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot run --post-merge --extra-stage "Build-Docker-Images, Release Check" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #28525 [ run ] triggered by Bot. Commit: f05880c

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot run --post-merge --extra-stage "Build-Docker-Images, Release Check" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #28527 [ run ] triggered by Bot. Commit: 8d5618d

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #28527 [ run ] completed with state FAILURE. Commit: 8d5618d
/LLM/main/L0_MergeRequest_PR pipeline #21848 completed with status: 'FAILURE'

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot run --post-merge --extra-stage "Build-Docker-Images, Release Check" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #28944 [ run ] triggered by Bot. Commit: 09cdd20

Signed-off-by: qqiao <[email protected]>
@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "Build-Docker-Images, Release Check" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #36857 [ run ] triggered by Bot. Commit: b960db9 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #36857 [ run ] completed with state SUCCESS. Commit: b960db9
/LLM/main/L0_MergeRequest_PR pipeline #28543 completed with status: 'SUCCESS'

Link to invocation

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "Build-Docker-Images, Release Check" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #37048 [ run ] triggered by Bot. Commit: 5830d3a Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #37048 [ run ] completed with state SUCCESS. Commit: 5830d3a
/LLM/main/L0_MergeRequest_PR pipeline #28684 completed with status: 'SUCCESS'

Link to invocation

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot run --extra-stage "Build-Docker-Images, Release Check" --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42113 [ run ] triggered by Bot. Commit: 01dae01 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42113 [ run ] completed with state SUCCESS. Commit: 01dae01
/LLM/main/L0_MergeRequest_PR pipeline #32951 completed with status: 'SUCCESS'

CI Report

Link to invocation

Copy link
Copy Markdown
Collaborator

@mzweilz mzweilz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, with this PR merged, can we still see the corresponding failure stage in red/yellow in the CI report when triaging post merge failures?

Signed-off-by: Emma Qiao <[email protected]>
Signed-off-by: Emma Qiao <[email protected]>
@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

Just curious, with this PR merged, can we still see the corresponding failure stage in red/yellow in the CI report when triaging post merge failures?

The stage will show fail/unstable but the whole pipeline will be green, see this job: https://prod.blsm.nvidia.com/sw-tensorrt-top-1/blue/organizations/jenkins/LLM%2Fmain%2FL0_MergeRequest_PR/detail/L0_MergeRequest_PR/32951/pipeline

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot run --post-merge

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42524 [ run ] triggered by Bot. Commit: 5176592 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42524 [ run ] completed with state SUCCESS. Commit: 5176592
/LLM/main/L0_MergeRequest_PR pipeline #33266 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot run --post-merge

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42986 [ run ] triggered by Bot. Commit: 5176592 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42986 [ run ] completed with state SUCCESS. Commit: 5176592
/LLM/main/L0_MergeRequest_PR pipeline #33641 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@EmmaQiaoCh
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Test the scenario in previous CIs"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43726 [ skip ] triggered by Bot. Commit: 5176592 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43726 [ skip ] completed with state SUCCESS. Commit: 5176592
Skipping testing for commit 5176592

Link to invocation

@EmmaQiaoCh EmmaQiaoCh enabled auto-merge (squash) April 17, 2026 02:23
@EmmaQiaoCh EmmaQiaoCh merged commit 07f8672 into NVIDIA:main Apr 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants