Skip to content

Conversation

@SimengLiu-nv
Copy link
Collaborator

@SimengLiu-nv SimengLiu-nv commented Nov 4, 2025

Plan to deprecate triton_server + multimodal.
Removed related tests in this PR.
Will remove related code bodies in follow-up PRs.

Summary by CodeRabbit

  • Tests
    • Removed obsolete test configurations from test suite

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@SimengLiu-nv
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

📝 Walkthrough

Walkthrough

Test configuration file updated to remove mistral-related entries from Triton groups within multiple test blocks, including pre/post merge sets and backend fmha sections.

Changes

Cohort / File(s) Summary
Test Configuration Cleanup
tests/integration/test_lists/test-db/l0_a100.yml
Removed six mistral tests from post-merge Triton group in pre/post merge sets block; removed nine mistral tests from post-merge Triton group in backend fmha block

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Verify all removed mistral test entries were intentional deletions
  • Confirm no unintended removals of non-mistral tests occurred

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is incomplete. Missing required sections: Description (explaining issue/solution), Test Coverage (relevant tests), and PR title following template format. Add PR title with ticket format and type (e.g., [TRTLLM-1234][chore]). Fill Description section explaining the deprecation rationale. List Test Coverage details for removed tests. Complete the PR Checklist.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title '[https://nvbugs/5606136][ci] Remove tests for deprecating models.' is specific and clearly describes the main change - removing tests related to deprecating models in CI configuration.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23546 [ run ] triggered by Bot. Commit: 1f15254

@schetlur-nv
Copy link
Collaborator

Can we expand the scope of this MR to just deprecate all TRT flow multimodal models? i.e. update doc for all of these, and then remove the test for them? This change seems only to appy to pixtral models.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23546 [ run ] completed with state FAILURE. Commit: 1f15254
/LLM/main/L0_MergeRequest_PR pipeline #17720 completed with status: 'FAILURE'

@SimengLiu-nv SimengLiu-nv requested review from juney-nvidia and laikhtewari and removed request for Tabrizian November 6, 2025 22:22
@SimengLiu-nv
Copy link
Collaborator Author

/bot run

@SimengLiu-nv SimengLiu-nv enabled auto-merge (squash) November 6, 2025 23:17
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23777 [ run ] triggered by Bot. Commit: 473f317

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23777 [ run ] completed with state SUCCESS. Commit: 473f317
/LLM/main/L0_MergeRequest_PR pipeline #17897 completed with status: 'SUCCESS'

@SimengLiu-nv SimengLiu-nv merged commit 9f8d93f into NVIDIA:main Nov 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants