Skip to content

Conversation

@ruoqianguo
Copy link
Collaborator

@ruoqianguo ruoqianguo commented Oct 20, 2025

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@ruoqianguo ruoqianguo requested a review from a team as a code owner October 20, 2025 03:27
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025

📝 Walkthrough

Walkthrough

Submodule pointer for 3rdparty/DeepGEMM updated from commit 0315934ce27c5c0b05dfff1a5eb101a5f8872cfe to 9fa5965e265e27995f539e0dd73a06351a8a9eaf with no functional or behavioral changes.

Changes

Cohort / File(s) Summary
Submodule update
3rdparty/DeepGEMM
Pointer updated to new commit; no functional changes

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~1 minute

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description contains the repository template structure but lacks substantive content in critical sections. The "Description" section is entirely empty with only the template comment placeholder and no explanation of what is being changed or why. Similarly, the "Test Coverage" section is empty with no listing of relevant tests. While the PR has a properly formatted title (following the template format with ticket/issue number and type), the author has not actually filled in the required sections to explain the changes. The PR Checklist shows only the final checkbox marked without evidence that the preceding items were reviewed or appropriate for this submodule update. The pull request essentially submits the template boilerplate unchanged rather than providing the necessary context for reviewers. The author should fill in the "Description" section with an explanation of why the 3rdparty/DeepGEMM submodule is being updated and what benefits or fixes this brings. The "Test Coverage" section should document which tests validate this submodule update. The PR Checklist items should be reviewed and checked off with indication of whether each item applies to this change (for example, clarifying whether new dependencies need scanning or if documentation updates are necessary for a submodule pointer update).
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Title Check ✅ Passed The PR title "Update 3rdparty/DeepGEMM to latest commit" is directly related to the primary change in the changeset, which updates the submodule pointer for 3rdparty/DeepGEMM from one commit to another. The title accurately captures the main objective and is specific enough that a reviewer can understand the purpose of the change. While the "[None][feat]" prefix appears unusual, the core message of the title clearly summarizes the modification being made to the repository.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Ruoqian Guo <[email protected]>
@ruoqianguo ruoqianguo changed the title [#8405][feat]Update 3rdparty/DeepGEMM to latest commit [None][feat]Update 3rdparty/DeepGEMM to latest commit Oct 20, 2025
@ruoqianguo ruoqianguo changed the title [None][feat]Update 3rdparty/DeepGEMM to latest commit [None][feat] Update 3rdparty/DeepGEMM to latest commit Oct 20, 2025
@ruoqianguo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21853 [ run ] triggered by Bot. Commit: a0732e4

Signed-off-by: Ruoqian Guo <[email protected]>
@ruoqianguo
Copy link
Collaborator Author

/bot kill

@ruoqianguo
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21858 [ kill ] triggered by Bot. Commit: 931c558

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21853 [ run ] completed with state ABORTED. Commit: a0732e4
LLM/main/L0_MergeRequest_PR #16474 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21858 [ kill ] completed with state SUCCESS. Commit: 931c558
Successfully killed previous jobs for commit 931c558

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21859 [ run ] triggered by Bot. Commit: 931c558

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21859 [ run ] completed with state SUCCESS. Commit: 931c558
/LLM/main/L0_MergeRequest_PR pipeline #16478 completed with status: 'FAILURE'

@Barry-Delaney
Copy link
Collaborator

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21891 [ run ] triggered by Bot. Commit: 6d34ace

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21891 [ run ] completed with state SUCCESS. Commit: 6d34ace
/LLM/main/L0_MergeRequest_PR pipeline #16506 completed with status: 'FAILURE'

@chang-l
Copy link
Collaborator

chang-l commented Oct 20, 2025

/bot run

@chang-l chang-l enabled auto-merge (squash) October 20, 2025 17:32
Copy link
Collaborator

@chang-l chang-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ruoqianguo

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21939 [ run ] triggered by Bot. Commit: 6d34ace

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21939 [ run ] completed with state SUCCESS. Commit: 6d34ace
/LLM/main/L0_MergeRequest_PR pipeline #16538 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@juney-nvidia juney-nvidia requested a review from atrifex October 20, 2025 22:55
@chang-l chang-l merged commit 984d4fe into NVIDIA:main Oct 20, 2025
5 checks passed
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Signed-off-by: Ruoqian Guo <[email protected]>
Co-authored-by: Barry Kang <[email protected]>
Signed-off-by: yufeiwu-nv <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants