[TRTLLM-8638][fix] Remove closed bugs #8478

xinhe-nv · 2025-10-19T12:17:09Z

Remove closed bugs from waives.txt

Summary by CodeRabbit

Tests
- Updated test waiver list entries to refine test case coverage.

xinhe-nv · 2025-10-20T10:19:40Z

/bot run

coderabbitai · 2025-10-20T10:21:48Z

📝 Walkthrough

Walkthrough

The PR updates test waiver entries in tests/integration/test_lists/waives.txt, removing some waived test cases and adding new ones. No executable logic, control flow, or error handling changes are involved.

Changes

Cohort / File(s)	Summary
Test waiver list `tests/integration/test_lists/waives.txt`	Removed and added waiver entries for integration test cases

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

NVIDIA/TensorRT-LLM#8151: Modifies the same waiver list file with test waiver changes
NVIDIA/TensorRT-LLM#6772: Updates waives.txt skip directives for integration tests
NVIDIA/TensorRT-LLM#7408: Adds/removes waiver entries in tests/integration/test_lists/waives.txt

Suggested reviewers

crazydemo
LarryXFly

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description is largely incomplete when compared against the required template structure. While the author provided a brief statement "Remove closed bugs from waives.txt" that relates to the PR's purpose, critical sections are missing or unfilled: the Test Coverage section contains no information about relevant tests, the PR Checklist items are entirely unchecked, and the description lacks substantive explanation of the issue, solution, and justification for the changes. For a chore PR, even though the changes are to a test configuration file only, the description should still provide basic context and confirmation of the checklist items.	Please expand the PR description to include: a brief explanation under the Description section clarifying why these bugs are no longer needed in the waives file, a Test Coverage section identifying which tests validate this change, and completion of the PR Checklist by marking items that have been reviewed or are not applicable to this chore. At minimum, the checklist item confirming appropriate reviewers should be marked.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.
Title Check	✅ Passed	The PR title "[TRTLLM-8638][fix] Remove closed bugs" directly aligns with the primary change in the changeset. The raw summary confirms that several waiver-list entries were removed from tests/integration/test_lists/waives.txt, and the PR description explicitly states "Remove closed bugs from waives.txt". The title is concise, clear, and includes a ticket reference and category label without extraneous noise. A teammate scanning the history would easily understand that this PR removes closed bugs from the project's waiver list.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2025-10-20T10:25:16Z

PR_Github #21900 [ run ] triggered by Bot. Commit: eb52d85

tensorrt-cicd · 2025-10-20T11:47:54Z

PR_Github #21900 [ run ] completed with state SUCCESS. Commit: eb52d85
/LLM/main/L0_MergeRequest_PR pipeline #16510 completed with status: 'FAILURE'

xinhe-nv · 2025-10-21T01:17:44Z

/bot run

tensorrt-cicd · 2025-10-21T01:22:56Z

PR_Github #21971 [ run ] triggered by Bot. Commit: 97e568f

tensorrt-cicd · 2025-10-21T03:14:02Z

PR_Github #21971 [ run ] completed with state SUCCESS. Commit: 97e568f
/LLM/main/L0_MergeRequest_PR pipeline #16567 completed with status: 'FAILURE'

xinhe-nv · 2025-10-21T03:33:25Z

/bot run

tensorrt-cicd · 2025-10-21T03:38:35Z

PR_Github #21991 [ run ] triggered by Bot. Commit: 14c9f4b

tensorrt-cicd · 2025-10-21T07:10:52Z

PR_Github #21991 [ run ] completed with state SUCCESS. Commit: 14c9f4b
/LLM/main/L0_MergeRequest_PR pipeline #16581 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

Signed-off-by: xinhe-nv <[email protected]>

Signed-off-by: Xin He (SW-GPU) <[email protected]>

xinhe-nv · 2025-10-21T07:14:41Z

/bot reuse-pipeline

tensorrt-cicd · 2025-10-21T07:20:17Z

PR_Github #22019 [ reuse-pipeline ] triggered by Bot. Commit: cdde64e

tensorrt-cicd · 2025-10-21T07:48:55Z

PR_Github #22019 [ reuse-pipeline ] completed with state SUCCESS. Commit: cdde64e
Reusing PR_Github #21991 for commit cdde64e

Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Xin He (SW-GPU) <[email protected]>

Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Xin He (SW-GPU) <[email protected]> Signed-off-by: yufeiwu-nv <[email protected]>

Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Xin He (SW-GPU) <[email protected]>

xinhe-nv requested review from LarryXFly and crazydemo October 19, 2025 12:17

xinhe-nv marked this pull request as ready for review October 20, 2025 10:19

xinhe-nv force-pushed the user/qa/unwaive_20251019 branch from 7c938a3 to eb52d85 Compare October 20, 2025 10:19

xinhe-nv force-pushed the user/qa/unwaive_20251019 branch from eb52d85 to 97e568f Compare October 21, 2025 01:16

xinhe-nv force-pushed the user/qa/unwaive_20251019 branch 2 times, most recently from 8658861 to 14c9f4b Compare October 21, 2025 03:32

xinhe-nv force-pushed the user/qa/unwaive_20251019 branch from 14c9f4b to 896679c Compare October 21, 2025 06:01

xinhe-nv changed the title ~~[None][chore] Remove closed bugs~~ [TRTLLM-8638][fix] Remove closed bugs Oct 21, 2025

xinhe-nv enabled auto-merge (squash) October 21, 2025 06:02

xinhe-nv added 2 commits October 21, 2025 15:14

update waive list

f9be379

Signed-off-by: xinhe-nv <[email protected]>

unwaive tests

cdde64e

Signed-off-by: Xin He (SW-GPU) <[email protected]>

xinhe-nv force-pushed the user/qa/unwaive_20251019 branch from 896679c to cdde64e Compare October 21, 2025 07:14

crazydemo approved these changes Oct 21, 2025

View reviewed changes

LarryXFly approved these changes Oct 21, 2025

View reviewed changes

xinhe-nv merged commit c566890 into NVIDIA:main Oct 21, 2025
5 checks passed

xinhe-nv deleted the user/qa/unwaive_20251019 branch October 21, 2025 07:50

govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025

[TRTLLM-8638][fix] Remove closed bugs (NVIDIA#8478)

0a0bebb

Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Xin He (SW-GPU) <[email protected]>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025

[TRTLLM-8638][fix] Remove closed bugs (NVIDIA#8478)

ee2860e

Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Xin He (SW-GPU) <[email protected]>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025

[TRTLLM-8638][fix] Remove closed bugs (NVIDIA#8478)

1166f5b

Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Xin He (SW-GPU) <[email protected]>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025

[TRTLLM-8638][fix] Remove closed bugs (NVIDIA#8478)

d5e4697

Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Xin He (SW-GPU) <[email protected]>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025

[TRTLLM-8638][fix] Remove closed bugs (NVIDIA#8478)

b59639f

Signed-off-by: xinhe-nv <[email protected]> Signed-off-by: Xin He (SW-GPU) <[email protected]>

coderabbitai bot mentioned this pull request Nov 24, 2025

[None][chore] Remove closed bugs #9381

Merged

coderabbitai bot mentioned this pull request Dec 8, 2025

[None][chore] Remove closed bugs #9770

Merged

[TRTLLM-8638][fix] Remove closed bugs #8478

[TRTLLM-8638][fix] Remove closed bugs #8478

Uh oh!

Conversation

xinhe-nv commented Oct 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

xinhe-nv commented Oct 20, 2025

Uh oh!

coderabbitai bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

tensorrt-cicd commented Oct 20, 2025

Uh oh!

tensorrt-cicd commented Oct 20, 2025

Uh oh!

xinhe-nv commented Oct 21, 2025

Uh oh!

tensorrt-cicd commented Oct 21, 2025

Uh oh!

tensorrt-cicd commented Oct 21, 2025

Uh oh!

xinhe-nv commented Oct 21, 2025

Uh oh!

tensorrt-cicd commented Oct 21, 2025

Uh oh!

tensorrt-cicd commented Oct 21, 2025

Uh oh!

xinhe-nv commented Oct 21, 2025

Uh oh!

tensorrt-cicd commented Oct 21, 2025

Uh oh!

tensorrt-cicd commented Oct 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xinhe-nv commented Oct 19, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Oct 20, 2025 •

edited

Loading