-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[#8461][feat] AutoDeploy: trtllm-serve bug fix + unit test #8462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8461][feat] AutoDeploy: trtllm-serve bug fix + unit test #8462
Conversation
|
/bot run |
📝 WalkthroughWalkthroughThe changes add validation logic to handle Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes The validation changes follow a straightforward repetitive pattern applied to two classes with identical logic. The new test module, while more involved with multiprocessing and integration concerns, implements a standard testing pattern for validating server functionality. The overall complexity is driven by familiar patterns rather than intricate logic or architectural changes. Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tensorrt_llm/_torch/auto_deploy/llm_args.py (1)
1-1: Add NVIDIA Apache-2.0 header (2025).Required by project guidelines; prepend the header.
[ suggest_essential_refactor ]
Apply at file top:+# Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License.As per coding guidelines.
🧹 Nitpick comments (3)
tensorrt_llm/_torch/auto_deploy/llm_args.py (1)
127-132: Simplify default_factory; avoid unused kwargs.No need for
**kwargs; use a zero-arg factory.- kv_cache_config: KvCacheConfig = Field( - default_factory=lambda **kwargs: KvCacheConfig(copy_on_partial_reuse=False, **kwargs), - description="KV cache config.", - ) + kv_cache_config: KvCacheConfig = Field( + default_factory=lambda: KvCacheConfig(copy_on_partial_reuse=False), + description="KV cache config.", + )tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py (2)
17-23: Improve failure diagnostics from Click runner.Capture output/exception for easier debugging in CI.
-def _run_serve_with_click(args): - runner = CliRunner() - # Blocks while server runs - result = runner.invoke(serve_main, args, catch_exceptions=False) - if result.exit_code != 0: - raise SystemExit(result.exit_code) +def _run_serve_with_click(args): + runner = CliRunner() + # Blocks while server runs + result = runner.invoke(serve_main, args, catch_exceptions=True) + if result.exception is not None: + print(result.output) + raise result.exception + if result.exit_code != 0: + print(result.output) + raise SystemExit(result.exit_code)
68-82: Make readiness timeout configurable and address TRY003 hint.Allow longer startups on slow CI and avoid long exception strings.
- start_time = time.time() + start_time = time.time() + ready_timeout = int(os.environ.get("TRTLLM_SERVE_READY_TIMEOUT", "120")) last_err = None - while time.time() - start_time < 90: + while time.time() - start_time < ready_timeout: if not server.is_alive(): - raise RuntimeError("Server process exited prematurely") + pytest.fail("Server process exited prematurely") try: # Lightweight readiness probe _ = client.models.list() break except Exception as e: # noqa: BLE001 last_err = e time.sleep(1) else: - raise TimeoutError(f"Server did not become ready in time: {last_err}") + pytest.fail(f"Server did not become ready in time. Last error: {last_err!r}")
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
tensorrt_llm/_torch/auto_deploy/llm_args.py(2 hunks)tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tensorrt_llm/_torch/auto_deploy/llm_args.pytests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tensorrt_llm/_torch/auto_deploy/llm_args.pytests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tensorrt_llm/_torch/auto_deploy/llm_args.pytests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
🧬 Code graph analysis (2)
tensorrt_llm/_torch/auto_deploy/llm_args.py (2)
tensorrt_llm/llmapi/llm_args.py (1)
KvCacheConfig(1138-1272)tensorrt_llm/logger.py (1)
warning(132-133)
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py (1)
tests/unittest/_torch/auto_deploy/_utils_test/_model_test_utils.py (1)
get_small_model_config(510-551)
🪛 Ruff (0.14.0)
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
72-72: Avoid specifying long messages outside the exception class
(TRY003)
81-81: Avoid specifying long messages outside the exception class
(TRY003)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py (1)
9-9: Verify test import path stability for_model_test_utils.This relies on PYTHONPATH/test package setup. If flakiness occurs, switch to a package-relative import or adjust conftest to add the utils dir to
sys.path.
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Show resolved
Hide resolved
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Outdated
Show resolved
Hide resolved
|
PR_Github #21714 [ run ] triggered by Bot. Commit: |
2ez4bz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fixing this!
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Outdated
Show resolved
Hide resolved
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Outdated
Show resolved
Hide resolved
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Outdated
Show resolved
Hide resolved
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Outdated
Show resolved
Hide resolved
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Outdated
Show resolved
Hide resolved
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Outdated
Show resolved
Hide resolved
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Outdated
Show resolved
Hide resolved
e39400d to
7ebdf83
Compare
|
/bot run |
7ebdf83 to
616f20b
Compare
|
PR_Github #21720 [ run ] triggered by Bot. Commit: |
|
PR_Github #21714 [ run ] completed with state |
|
PR_Github #21720 [ run ] completed with state |
Signed-off-by: Lucas Liebenwein <[email protected]>
616f20b to
1ae9b55
Compare
|
/bot run |
|
PR_Github #21726 [ run ] triggered by Bot. Commit: |
govind-ramnarayan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! I have a question on why we've decided to modify in the validator and whether there are options. Beyond that some nits on putting certain things into helper functions in the test, feel free to take it or leave it depending on how generalizable you think the test is
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Show resolved
Hide resolved
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Show resolved
Hide resolved
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
Show resolved
Hide resolved
|
PR_Github #21726 [ run ] completed with state |
|
/bot run |
1 similar comment
|
/bot run |
|
PR_Github #21930 [ run ] triggered by Bot. Commit: |
|
PR_Github #21930 [ run ] completed with state |
…DIA#8462) Signed-off-by: Lucas Liebenwein <[email protected]>
…DIA#8462) Signed-off-by: Lucas Liebenwein <[email protected]> Signed-off-by: yufeiwu-nv <[email protected]>
…DIA#8462) Signed-off-by: Lucas Liebenwein <[email protected]>
…DIA#8462) Signed-off-by: Lucas Liebenwein <[email protected]>
…DIA#8462) Signed-off-by: Lucas Liebenwein <[email protected]>
…DIA#8462) Signed-off-by: Lucas Liebenwein <[email protected]>
Summary by CodeRabbit
Release Notes
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.