Skip to content

Conversation

@lucaslie
Copy link
Member

@lucaslie lucaslie commented Oct 17, 2025

Summary by CodeRabbit

Release Notes

  • Bug Fixes
    • KV cache configuration now includes improved runtime validation that automatically disables unsupported options and provides user warnings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@lucaslie lucaslie requested a review from a team as a code owner October 17, 2025 15:55
@lucaslie lucaslie requested a review from MrGeva October 17, 2025 15:55
@lucaslie lucaslie requested review from 2ez4bz and suyoggupta October 17, 2025 15:56
@lucaslie lucaslie moved this from Backlog to In review in AutoDeploy Board Oct 17, 2025
@lucaslie
Copy link
Member Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2025

📝 Walkthrough

Walkthrough

The changes add validation logic to handle kv_cache_config parameters in model argument classes, ensuring unsupported flags are disabled with warnings during initialization, and introduce a comprehensive integration test for TRT-Llama serving deployment with OpenAI-compatible client support.

Changes

Cohort / File(s) Summary
KV Cache Config Validation
tensorrt_llm/_torch/auto_deploy/llm_args.py
Added imports for ad_logger and implemented two identical post-validation field validators (validate_kv_cache_config) in AutoDeployConfig and LlmArgs classes that disable copy_on_partial_reuse flag when kv_cache_config is set, logging a warning to inform users.
TRT-Llama Serving Integration Test
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
New test module implementing a full integration test for TRT-Llama serving with OpenAI-compatible client. Includes helper function _run_serve_with_click for CLI-based server startup and main test test_trtllm_serve_openai_chat_completion that validates server deployment, readiness polling, and chat completion API functionality with proper lifecycle management.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

The validation changes follow a straightforward repetitive pattern applied to two classes with identical logic. The new test module, while more involved with multiprocessing and integration concerns, implements a standard testing pattern for validating server functionality. The overall complexity is driven by familiar patterns rather than intricate logic or architectural changes.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The PR description is largely incomplete and consists only of template placeholders. The critical sections required by the repository template—specifically the "Description" section (explaining the issue and solution) and the "Test Coverage" section (listing relevant tests)—are entirely empty with only HTML comment placeholders. While the PR title is present and one checklist item is marked, the substantive content necessary for reviewers to understand what is being fixed and how it is tested is completely missing. The author should fill in the "Description" section with a clear explanation of the bug being fixed (the kv_cache_config validation issue) and the solution implemented. The "Test Coverage" section should document the new unit test (test_trtllm_serve_openai_chat_completion) and explain what it validates. These additions will provide essential context for reviewers to properly assess the changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[#8461][feat] AutoDeploy: trtllm-serve bug fix + unit test" is directly related to the changes in the pull request. The title accurately identifies both major components of the changeset: the bug fix in llm_args.py (adding kv_cache_config validators to AutoDeployConfig and LlmArgs) and the new unit test in test_ad_trtllm_serve.py. The title follows the repository's template format with the ticket reference and type indicator, and it is sufficiently specific for a developer scanning history to understand the primary change involves AutoDeploy's trtllm-serve functionality.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
tensorrt_llm/_torch/auto_deploy/llm_args.py (1)

1-1: Add NVIDIA Apache-2.0 header (2025).

Required by project guidelines; prepend the header.

[ suggest_essential_refactor ]
Apply at file top:

+# Copyright (c) 2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.

As per coding guidelines.

🧹 Nitpick comments (3)
tensorrt_llm/_torch/auto_deploy/llm_args.py (1)

127-132: Simplify default_factory; avoid unused kwargs.

No need for **kwargs; use a zero-arg factory.

-    kv_cache_config: KvCacheConfig = Field(
-        default_factory=lambda **kwargs: KvCacheConfig(copy_on_partial_reuse=False, **kwargs),
-        description="KV cache config.",
-    )
+    kv_cache_config: KvCacheConfig = Field(
+        default_factory=lambda: KvCacheConfig(copy_on_partial_reuse=False),
+        description="KV cache config.",
+    )
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py (2)

17-23: Improve failure diagnostics from Click runner.

Capture output/exception for easier debugging in CI.

-def _run_serve_with_click(args):
-    runner = CliRunner()
-    # Blocks while server runs
-    result = runner.invoke(serve_main, args, catch_exceptions=False)
-    if result.exit_code != 0:
-        raise SystemExit(result.exit_code)
+def _run_serve_with_click(args):
+    runner = CliRunner()
+    # Blocks while server runs
+    result = runner.invoke(serve_main, args, catch_exceptions=True)
+    if result.exception is not None:
+        print(result.output)
+        raise result.exception
+    if result.exit_code != 0:
+        print(result.output)
+        raise SystemExit(result.exit_code)

68-82: Make readiness timeout configurable and address TRY003 hint.

Allow longer startups on slow CI and avoid long exception strings.

-            start_time = time.time()
+            start_time = time.time()
+            ready_timeout = int(os.environ.get("TRTLLM_SERVE_READY_TIMEOUT", "120"))
             last_err = None
-            while time.time() - start_time < 90:
+            while time.time() - start_time < ready_timeout:
                 if not server.is_alive():
-                    raise RuntimeError("Server process exited prematurely")
+                    pytest.fail("Server process exited prematurely")
                 try:
                     # Lightweight readiness probe
                     _ = client.models.list()
                     break
                 except Exception as e:  # noqa: BLE001
                     last_err = e
                     time.sleep(1)
             else:
-                raise TimeoutError(f"Server did not become ready in time: {last_err}")
+                pytest.fail(f"Server did not become ready in time. Last error: {last_err!r}")
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8d07580 and d1f4013.

📒 Files selected for processing (2)
  • tensorrt_llm/_torch/auto_deploy/llm_args.py (2 hunks)
  • tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tensorrt_llm/_torch/auto_deploy/llm_args.py
  • tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tensorrt_llm/_torch/auto_deploy/llm_args.py
  • tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tensorrt_llm/_torch/auto_deploy/llm_args.py
  • tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py
🧬 Code graph analysis (2)
tensorrt_llm/_torch/auto_deploy/llm_args.py (2)
tensorrt_llm/llmapi/llm_args.py (1)
  • KvCacheConfig (1138-1272)
tensorrt_llm/logger.py (1)
  • warning (132-133)
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py (1)
tests/unittest/_torch/auto_deploy/_utils_test/_model_test_utils.py (1)
  • get_small_model_config (510-551)
🪛 Ruff (0.14.0)
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py

72-72: Avoid specifying long messages outside the exception class

(TRY003)


81-81: Avoid specifying long messages outside the exception class

(TRY003)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/unittest/_torch/auto_deploy/unit/singlegpu/test_ad_trtllm_serve.py (1)

9-9: Verify test import path stability for _model_test_utils.

This relies on PYTHONPATH/test package setup. If flakiness occurs, switch to a package-relative import or adjust conftest to add the utils dir to sys.path.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21714 [ run ] triggered by Bot. Commit: d1f4013

Copy link
Collaborator

@2ez4bz 2ez4bz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@lucaslie lucaslie self-assigned this Oct 17, 2025
@lucaslie lucaslie changed the title [#8460][feat] AutoDeploy: trtllm-serve bug fix + unit test [#8461][feat] AutoDeploy: trtllm-serve bug fix + unit test Oct 17, 2025
@lucaslie lucaslie linked an issue Oct 17, 2025 that may be closed by this pull request
1 task
@lucaslie lucaslie force-pushed the ll/trtllm_serve_with_unit_test branch from e39400d to 7ebdf83 Compare October 17, 2025 17:04
@lucaslie
Copy link
Member Author

/bot run

@lucaslie lucaslie enabled auto-merge (squash) October 17, 2025 17:07
@lucaslie lucaslie force-pushed the ll/trtllm_serve_with_unit_test branch from 7ebdf83 to 616f20b Compare October 17, 2025 17:09
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21720 [ run ] triggered by Bot. Commit: 616f20b

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21714 [ run ] completed with state ABORTED. Commit: d1f4013
LLM/main/L0_MergeRequest_PR #16362 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21720 [ run ] completed with state SUCCESS. Commit: 616f20b
/LLM/main/L0_MergeRequest_PR pipeline #16366 completed with status: 'FAILURE'

@lucaslie lucaslie force-pushed the ll/trtllm_serve_with_unit_test branch from 616f20b to 1ae9b55 Compare October 17, 2025 21:00
@lucaslie
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21726 [ run ] triggered by Bot. Commit: 1ae9b55

Copy link
Collaborator

@govind-ramnarayan govind-ramnarayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I have a question on why we've decided to modify in the validator and whether there are options. Beyond that some nits on putting certain things into helper functions in the test, feel free to take it or leave it depending on how generalizable you think the test is

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21726 [ run ] completed with state SUCCESS. Commit: 1ae9b55
/LLM/main/L0_MergeRequest_PR pipeline #16373 completed with status: 'FAILURE'

@lucaslie
Copy link
Member Author

/bot run

1 similar comment
@lucaslie
Copy link
Member Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21930 [ run ] triggered by Bot. Commit: 1ae9b55

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21930 [ run ] completed with state SUCCESS. Commit: 1ae9b55
/LLM/main/L0_MergeRequest_PR pipeline #16532 completed with status: 'SUCCESS'

@lucaslie lucaslie merged commit 55c468b into NVIDIA:main Oct 20, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AutoDeploy Board Oct 20, 2025
@lucaslie lucaslie deleted the ll/trtllm_serve_with_unit_test branch October 20, 2025 20:31
govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Feature]: [AutoDeploy]: trtllm-serve unit test

6 participants