[None][feat] Update devcontainer configuration to include additional extensions #8369

Funatiq · 2025-10-14T13:53:32Z

Summary by CodeRabbit

Chores
- Updated the development environment to include extensions for pull request management and Markdown linting in the container.
- Improves consistency of Markdown formatting and streamlines review workflows during development.
- No changes to application features, UI, performance, or runtime behavior.

Description

Added 'davidanson.vscode-markdownlint' to the list of extensions.
Enabled 'GitHub.vscode-pull-request-github' in the devcontainer setup.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

…extensions - Added 'davidanson.vscode-markdownlint' to the list of extensions. - Enabled 'GitHub.vscode-pull-request-github' in the devcontainer setup. Signed-off-by: Robin Kobus <[email protected]>

coderabbitai · 2025-10-14T13:56:10Z

📝 Walkthrough

Walkthrough

Uncommented the GitHub Pull Requests extension and added the Markdownlint extension in the devcontainer configuration to adjust the default VS Code extensions for the development container. No code or exported entities were modified.

Changes

Cohort / File(s)	Summary
Devcontainer configuration `.devcontainer/devcontainer.json`	Uncommented `GitHub.vscode-pull-request-github` in extensions; added `davidanson.vscode-markdownlint` to the extensions list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description retains template placeholders and comments instead of providing a formatted title and concrete content. It does not include a PR title that follows the `[JIRA ticket/...][type] Summary` convention and leaves the Test Coverage section empty. These omissions mean the description does not conform to the repository’s required template.	Please add a properly formatted PR title at the top using the `[JIRA ticket/NVBugs ID/GitHub issue/None][type] Summary` template and populate the Test Coverage section with any relevant tests or state that none are needed. Ensure template comments are removed once sections are filled.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title adheres to the repository’s template by including “[None][feat]” and succinctly describes the main change of updating the devcontainer configuration to add and enable additional VS Code extensions, directly matching the modifications in the pull request.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai · 2025-10-14T13:56:24Z

📝 Walkthrough

Walkthrough

Enables additional VS Code extensions in the development container by activating the GitHub Pull Request extension and adding Markdown linting.

Changes

Cohort / File(s)	Summary of Changes
Devcontainer config `\.devcontainer/devcontainer.json`	Uncommented and enabled "GitHub.vscode-pull-request-github"; added "davidanson.vscode-markdownlint" to the extensions list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The pull request description includes a clear Description section listing the addition of the markdownlint extension and the enabling of the GitHub Pull Request extension along with a PR Checklist, but the Test Coverage section is present yet contains no actual test cases or verification steps for these devcontainer updates.	Please populate the Test Coverage section with specific tests or validation steps that ensure the new extensions are correctly installed and enabled in the devcontainer, and consider removing any leftover template comments to improve clarity.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title succinctly follows the repository’s naming convention and accurately summarizes the primary change by indicating an update to the devcontainer configuration to include additional extensions, which directly reflects the modifications made in the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7291cdc and c2a449e.

📒 Files selected for processing (1)

.devcontainer/devcontainer.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (1)

.devcontainer/devcontainer.json (1)

39-43: Additions look good.

Enabling the GitHub PR tooling and markdown linting aligns with the devcontainer’s purpose and should improve the contributor workflow.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ixlmar

LGTM

Funatiq · 2025-10-15T11:09:55Z

/bot skip --comment "CI is not affected by changes"

tensorrt-cicd · 2025-10-15T11:15:24Z

PR_Github #21476 [ skip ] triggered by Bot

tensorrt-cicd · 2025-10-15T11:41:57Z

PR_Github #21476 [ skip ] completed with state SUCCESS
Skipping testing for commit c2a449e

…extensions (NVIDIA#8369) Signed-off-by: Robin Kobus <[email protected]>

…extensions (NVIDIA#8369) Signed-off-by: Robin Kobus <[email protected]> Signed-off-by: yufeiwu-nv <[email protected]>

…extensions (NVIDIA#8369) Signed-off-by: Robin Kobus <[email protected]>

[None][feat] Update devcontainer configuration to include additional …

c2a449e

…extensions - Added 'davidanson.vscode-markdownlint' to the list of extensions. - Enabled 'GitHub.vscode-pull-request-github' in the devcontainer setup. Signed-off-by: Robin Kobus <[email protected]>

Funatiq requested a review from ixlmar October 14, 2025 13:53

Funatiq marked this pull request as ready for review October 14, 2025 13:53

ixlmar approved these changes Oct 15, 2025

View reviewed changes

Funatiq merged commit 18c7a52 into NVIDIA:main Oct 20, 2025
8 of 11 checks passed

Funatiq deleted the dev/devcontainers_add_extensions branch October 20, 2025 10:29

govind-ramnarayan pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Oct 21, 2025

[None][feat] Update devcontainer configuration to include additional …

aca9cb4

…extensions (NVIDIA#8369) Signed-off-by: Robin Kobus <[email protected]>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025

[None][feat] Update devcontainer configuration to include additional …

63ba3f7

…extensions (NVIDIA#8369) Signed-off-by: Robin Kobus <[email protected]>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025

[None][feat] Update devcontainer configuration to include additional …

91c07ff

…extensions (NVIDIA#8369) Signed-off-by: Robin Kobus <[email protected]>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025

[None][feat] Update devcontainer configuration to include additional …

724069a

…extensions (NVIDIA#8369) Signed-off-by: Robin Kobus <[email protected]>

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025

[None][feat] Update devcontainer configuration to include additional …

f19553e

…extensions (NVIDIA#8369) Signed-off-by: Robin Kobus <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[None][feat] Update devcontainer configuration to include additional extensions #8369

[None][feat] Update devcontainer configuration to include additional extensions #8369

Uh oh!

Funatiq commented Oct 14, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 14, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai bot commented Oct 14, 2025

Walkthrough

Changes

Estimated code review effort

Uh oh!

ixlmar left a comment

Uh oh!

Funatiq commented Oct 15, 2025

Uh oh!

tensorrt-cicd commented Oct 15, 2025

Uh oh!

tensorrt-cicd commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[None][feat] Update devcontainer configuration to include additional extensions #8369

[None][feat] Update devcontainer configuration to include additional extensions #8369

Uh oh!

Conversation

Funatiq commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

coderabbitai bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot commented Oct 14, 2025

Walkthrough

Changes

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

ixlmar left a comment

Choose a reason for hiding this comment

Uh oh!

Funatiq commented Oct 15, 2025

Uh oh!

tensorrt-cicd commented Oct 15, 2025

Uh oh!

tensorrt-cicd commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Funatiq commented Oct 14, 2025 •

edited

Loading

coderabbitai bot commented Oct 14, 2025 •

edited

Loading