Skip to content

Conversation

@xxi-nv
Copy link
Collaborator

@xxi-nv xxi-nv commented Oct 7, 2025

Summary by CodeRabbit

  • Tests
    • Re-enabled a previously skipped FP8 blockwise Mixture-of-Experts test, improving coverage for wide expert-parallel configurations.
    • Updated test invocations to align with current APIs by removing a redundant argument and validating token-count handling and data-parallel padding paths.
    • No user-facing behavior changes; improvements are limited to test reliability and CI coverage.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 7, 2025

📝 Walkthrough

Walkthrough

Unskips a previously skipped test and updates FP8 blockwise test calls by removing the all_rank_max_num_tokens argument, retaining all_rank_num_tokens and use_dp_padding.

Changes

Cohort / File(s) Summary
Tests: Fused MoE FP8 blockwise
tests/unittest/_torch/modules/test_fused_moe.py
Removed @Skip on test_fused_moe_fp8_blockwise_wide_ep; updated per_rank_test_fused_moe_alltoall_fp8_blockwise to drop all_rank_max_num_tokens parameter from ref_model.forward and forward calls.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request description is largely unchanged from the template and only contains commented instructions with no actual content in the Description or Test Coverage sections, and it does not include the required PR title in the body. This omission makes it impossible to understand the change intent or verify test coverage, so it fails to meet the repository’s description template requirements. Please update the description to include the PR title in the specified ticket/type format, provide a concise explanation of the change and root cause under “## Description,” list relevant test cases under “## Test Coverage,” and ensure the PR Checklist items are appropriately addressed.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title correctly follows the repository template by including the NVBugs ID and the “[fix]” type, and it clearly summarizes the primary change of updating a test case to the latest MoE API as reflected in the diff.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xxi-nv
Copy link
Collaborator Author

xxi-nv commented Oct 7, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20704 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20710 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20704 [ run ] completed with state ABORTED
LLM/main/L0_MergeRequest_PR #15641 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20710 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15647 completed with status: 'SUCCESS'

@xxi-nv
Copy link
Collaborator Author

xxi-nv commented Oct 8, 2025

/bot run

@xxi-nv xxi-nv enabled auto-merge (squash) October 8, 2025 02:59
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20761 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20761 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15690 completed with status: 'SUCCESS'

@xxi-nv xxi-nv merged commit e986165 into NVIDIA:main Oct 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants