[None][infra] Waive failed tests in post-merge #7859

EmmaQiaoCh · 2025-09-19T05:25:12Z

Summary by CodeRabbit

Tests
- Updated automated test waivers to temporarily skip a few GPU-specific scenarios impacted by upstream issues, improving CI stability and reducing false negatives.
- This change only affects test selection and execution in pipelines; there are no changes to product features, performance, APIs, or user workflows.
- No action required from users; builds and releases remain unaffected.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: qqiao <[email protected]>

EmmaQiaoCh · 2025-09-19T05:26:15Z

/bot skip --comment "Just skip failed tests"

coderabbitai · 2025-09-19T05:29:49Z

📝 Walkthrough

Walkthrough

Added two SKIP entries to tests/integration/test_lists/waives.txt to skip specific failing tests linked to nvbugs 5527940 and 5528070. No other files or logic were changed.

Changes

Cohort / File(s)	Summary
Test waivers `tests/integration/test_lists/waives.txt`	Added SKIP entries for `examples/test_llama.py::test_llm_llama_1gpu_fp8_kv_cache[llama-v2-7b-hf-bfloat16]` (nvbugs/5527940) and `accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_bfloat16_4gpus[tp4-mtp_nextn=2-attention_dp=True-cuda_graph=True-overlap_scheduler=True-torch_compile=True]` (nvbugs/5528070).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

[None][infra] Waive failed tests on main 08/19 #7037 — Also adds SKIP entries in tests/integration/test_lists/waives.txt for failing tests.
[None][infra] Waive failed tests on main branch 0902 #7482 — Similar update to waives.txt to skip unstable tests.
[None][infra] Waive failed case on main 0901 #7447 — Modifies waives.txt to add SKIP entries for flaky tests.

Suggested reviewers

yiqingy0
chzblych
ZhanruiSunCh
niukuo

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR body contains the repository template and bot help text but does not provide a filled "Description" or "Test Coverage" explaining the rationale, affected files, or CI impact; the raw_summary shows two SKIP entries were added but those details and NVBugs links are not documented in the PR description. Required template sections are effectively empty, so reviewers lack context to evaluate why the waivers were added and whether they are acceptable. Because the description is missing required information, it does not meet the repository's PR description requirements.	Please update the PR description: fill the "Description" with a short rationale for waiving the tests and list the exact file edits, test names, and NVBugs links; populate "Test Coverage" to state which tests are affected and confirm there are no functional code changes and whether the waiver is post-merge only; and complete or comment on the PR checklist items (e.g., CODEOWNERS, documentation) so reviewers can assess impact.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "[None][infra] Waive failed tests in post-merge" is concise and directly summarizes the primary change (adding waivers to skip failing tests in post-merge) while using the repository's ticket/type prefix convention. It accurately reflects the edits shown in the raw summary (inserting SKIP entries into tests/integration/test_lists/waives.txt) and is specific enough for a reviewer scanning PR history. The title contains no extraneous details or misleading information.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fcc054 and c7f0dbf.

📒 Files selected for processing (1)

tests/integration/test_lists/waives.txt (1 hunks)

🧰 Additional context used

🧠 Learnings (6)

📓 Common learnings

Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

📚 Learning: 2025-09-17T02:48:52.732Z

Learnt from: tongyuantongyu
PR: NVIDIA/TensorRT-LLM#7781
File: tests/integration/test_lists/waives.txt:313-313
Timestamp: 2025-09-17T02:48:52.732Z
Learning: In TensorRT-LLM, `tests/integration/test_lists/waives.txt` is specifically for waiving/skipping tests, while other test list files like those in `test-db/` and `qa/` directories are for different test execution contexts (pre-merge, post-merge, QA tests). The same test appearing in both waives.txt and execution list files is intentional - the test is part of test suites but will be skipped due to the waiver.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-07-28T17:06:08.621Z

Learnt from: moraxu
PR: NVIDIA/TensorRT-LLM#6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-08-29T14:07:45.863Z

Learnt from: EmmaQiaoCh
PR: NVIDIA/TensorRT-LLM#7370
File: tests/unittest/trt/model_api/test_model_quantization.py:24-27
Timestamp: 2025-08-29T14:07:45.863Z
Learning: In TensorRT-LLM's CI infrastructure, pytest skip markers (pytest.mark.skip) are properly honored even when test files have __main__ blocks that call test functions directly. The testing system correctly skips tests without requiring modifications to the __main__ block execution pattern.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-09-09T09:40:45.658Z

Learnt from: fredricz-20070104
PR: NVIDIA/TensorRT-LLM#7645
File: tests/integration/test_lists/qa/llm_function_core.txt:648-648
Timestamp: 2025-09-09T09:40:45.658Z
Learning: In TensorRT-LLM test lists, it's common and intentional for the same test to appear in multiple test list files when they serve different purposes (e.g., llm_function_core.txt for comprehensive core functionality testing and llm_function_core_sanity.txt for quick sanity checks). This duplication allows tests to be run in different testing contexts.

Applied to files:

tests/integration/test_lists/waives.txt

📚 Learning: 2025-08-26T09:49:04.956Z

Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").

Applied to files:

tests/integration/test_lists/waives.txt

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Pre-commit Check

🔇 Additional comments (1)

tests/integration/test_lists/waives.txt (1)

349-351: Waives look correctly formatted — confirm test definitions and exact duplicates in test-db.

Entries follow the waives.txt format and include bug links.

The same parametrizations are present in test-db YAMLs (e.g., tests/integration/test_lists/test-db/l0_l40s.yml:94 and multiple l0_*.yml entries); CI tooling (scripts/check_test_list.py and Jenkins L0 pipeline) reads/merges waives.txt so these will be skipped.

Test definitions were not found at the searched paths (no top-level accuracy/ dir; examples/ search returned no matches). Provide or confirm the exact file paths for:

examples/test_llama.py::test_llm_llama_1gpu_fp8_kv_cache[llama-v2-7b-hf-bfloat16]

accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_bfloat16_4gpus[tp4-mtp_nextn=2-attention_dp=True-cuda_graph=True-overlap_scheduler=True-torch_compile=True]
so exact duplication and validity can be verified.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tensorrt-cicd · 2025-09-19T05:31:48Z

PR_Github #19284 [ skip ] triggered by Bot

Signed-off-by: qqiao <[email protected]>

EmmaQiaoCh · 2025-09-19T05:50:44Z

/bot skip --comment "Just skip failed tests"

tensorrt-cicd · 2025-09-19T05:51:54Z

PR_Github #19284 [ skip ] completed with state SUCCESS
Release Check Pipeline #2033 failed

tensorrt-cicd · 2025-09-19T05:56:07Z

PR_Github #19293 [ skip ] triggered by Bot

tensorrt-cicd · 2025-09-19T06:16:10Z

PR_Github #19293 [ skip ] completed with state SUCCESS
Skipping testing for commit 3f3a68c

Signed-off-by: qqiao <[email protected]>

Waive failed tests in post-merge

c7f0dbf

Signed-off-by: qqiao <[email protected]>

EmmaQiaoCh requested a review from chzblych September 19, 2025 05:25

EmmaQiaoCh enabled auto-merge (squash) September 19, 2025 05:26

Fix format

3f3a68c

Signed-off-by: qqiao <[email protected]>

chzblych approved these changes Sep 19, 2025

View reviewed changes

EmmaQiaoCh merged commit ea079fa into NVIDIA:main Sep 19, 2025
5 checks passed

dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Sep 19, 2025

[None][infra] Waive failed tests in post-merge (NVIDIA#7859)

9e3a4df

Signed-off-by: qqiao <[email protected]>

Wong4j pushed a commit to Wong4j/TensorRT-LLM that referenced this pull request Sep 20, 2025

[None][infra] Waive failed tests in post-merge (NVIDIA#7859)

1150ce2

Signed-off-by: qqiao <[email protected]>

MrGeva pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Sep 21, 2025

[None][infra] Waive failed tests in post-merge (NVIDIA#7859)

6c55fc0

Signed-off-by: qqiao <[email protected]>

coderabbitai bot mentioned this pull request Sep 22, 2025

[None][infra] Skip failed test for nvbugs 5532023 #7905

Merged

1 task

EmmaQiaoCh deleted the emma/waive_tests_main_0919 branch September 25, 2025 07:34

This was referenced Sep 25, 2025

[None][infra] Waive failed tests on main 09/25 #8001

Merged

[None][infra] Waive failed cases in post-merge 2305 #8019

Merged

[None][infra] Skip failed tests in post-merge for main #8102

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[None][infra] Waive failed tests in post-merge #7859

[None][infra] Waive failed tests in post-merge #7859

Uh oh!

EmmaQiaoCh commented Sep 19, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

EmmaQiaoCh commented Sep 19, 2025

Uh oh!

coderabbitai bot commented Sep 19, 2025

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

EmmaQiaoCh commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[None][infra] Waive failed tests in post-merge #7859

[None][infra] Waive failed tests in post-merge #7859

Uh oh!

Conversation

EmmaQiaoCh commented Sep 19, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Description

Test Coverage

PR Checklist

GitHub Bot Help

kill

skip

reuse-pipeline

Uh oh!

EmmaQiaoCh commented Sep 19, 2025

Uh oh!

coderabbitai bot commented Sep 19, 2025

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

EmmaQiaoCh commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

tensorrt-cicd commented Sep 19, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

EmmaQiaoCh commented Sep 19, 2025 •

edited by coderabbitai bot

Loading