[https://nvbugs/5485430][fix] Copy the nanobind file when using precompiled package #7334
Conversation
📝 WalkthroughWalkthroughUpdate packaging metadata: bump copyright year range to 2025 and add Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
jiaganc
requested review from
a team,
Shixiaowei02,
kxdc and
zeroepoch
and removed request for
a team
|
/bot run |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
setup.py (4)
205-210: python_requires is too permissive vs actual syntax used.This file uses PEP 604 unions (str | None), which require Python 3.10+. Please update python_requires to avoid installing on unsupported interpreters. (A separate comment addresses a 3.12-only tarfile API.)
Apply this diff:
- python_requires=">=3.7, <4") + python_requires=">=3.10, <4")Also applies to: 263-263
181-183: Bug: raising from undefined exception variable.In the tar.gz branch, you're doing
... from ewhereeis not defined in this scope.Apply this diff:
- else: - raise SetupError( - f"Failed to get wheel file from {precompiled_path}.") from e + else: + raise SetupError( + f"Failed to get wheel file from {precompiled_path}." + )
175-186: Python 3.12-only tarfile API used; add compatibility guard for 3.10/3.11.
tar.extract(..., filter=tarfile.data_filter)is only available in Python 3.12+. Guard it to retain 3.10 support (consistent with classifiers) while keeping the safer path on 3.12+.Apply this diff:
- tar.extract(member, path=workspace, filter=tarfile.data_filter) + if sys.version_info >= (3, 12): + tar.extract(member, path=workspace, filter=tarfile.data_filter) + else: + # Python <3.12: no `filter` kwarg; member is matched explicitly above. + tar.extract(member, path=workspace)
135-141: Use narrower exceptions and avoid indexing an empty glob result.Catching Exception swallows actionable errors; also
glob(...)[0]risks IndexError if no wheel is downloaded.Apply this diff:
- try: - subprocess.check_call(cmd) - wheel_path = glob.glob(f"{workspace}/tensorrt_llm-*.whl")[0] - except Exception as e: + try: + subprocess.check_call(cmd) + wheels = glob.glob(f"{workspace}/tensorrt_llm-*.whl") + if not wheels: + raise FileNotFoundError("Downloaded wheel not found") + wheel_path = wheels[0] + except subprocess.CalledProcessError as e: + raise SetupError( + "Failed to download the automatically resolved wheel, please try specifying TRTLLM_USE_PRECOMPILED with a link or local path to a valid wheel." + ) from e + except FileNotFoundError as e: raise SetupError( "Failed to download the automatically resolved wheel, please try specifying TRTLLM_USE_PRECOMPILED with a link or local path to a valid wheel." ) from e
🧹 Nitpick comments (4)
setup.py (4)
15-18: Import sys for the version guard.Apply this diff:
import os +import sys import platform from pathlib import Path from typing import List
154-156: Narrow the exception type when downloading via urlretrieve.Catching only URL-related errors avoids masking unrelated issues.
Apply this diff:
- from urllib.request import urlretrieve + from urllib.request import urlretrieve + from urllib.error import URLError, HTTPError @@ - except Exception as e: + except (URLError, HTTPError) as e: raise SetupError( f"Failed to get precompiled file from {precompiled_location}." ) from eAlso applies to: 167-173
1-2: Update copyright year to 2025 to meet guideline.Apply this diff:
-# SPDX-FileCopyrightText: Copyright (c) 2022-2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
20-21: Optional: preserve module namespace per guideline.Style-only; would require updating references to setup/find_packages/Distribution usages if changed.
Possible diff start:
-from setuptools import find_packages, setup -from setuptools.dist import Distribution +import setuptoolsAnd later:
- use
setuptools.find_packages()andsetuptools.setup(...)- make
class BinaryDistribution(setuptools.dist.Distribution):
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
setup.py(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Code must target Python 3.8+
Indent with 4 spaces; do not use tabs
Preserve module namespaces in imports: import the subpackage/module, not the symbol (from package.subpackage import foo; foo.SomeClass())
Naming: files snake_case; classes PascalCase; functions/methods snake_case; local variables snake_case (k_ prefix if starting with a number); globals G_ + UPPER_SNAKE_CASE; constants UPPER_SNAKE_CASE
Avoid shadowing outer-scope variables; initialize all externally visible members in init
Prefer docstrings for interfaces used outside a file; reserve comments for function-internal or file-local interfaces
Use Google-style docstrings for classes and functions; inline docstrings for attributes/variables are allowed
Avoid reflection when straightforward code suffices (e.g., prefer explicit parameters over dict(**locals()))
Use narrow except clauses (e.g., catch FileNotFoundError instead of bare except)
For duck-typing try/except, keep try body minimal and use else for the main logic
Files:
setup.py
**/*.{cpp,cc,cxx,cu,h,hpp,hh,hxx,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend NVIDIA copyright header with current year to all source files
Files:
setup.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
setup.py (1)
114-121: Including bindings.pyi fixes nanobind precompiled packaging.This ensures the nanobind stub is copied when repackaging from a precompiled wheel; .pyi files are not filtered out in extract_from_precompiled, so this will be included. LGTM.
|
PR_Github #16829 [ run ] triggered by Bot |
|
PR_Github #16829 [ run ] completed with state |
jiaganc
force-pushed
the
dev-jiaganc-fix-precompiled-nanobind
branch
from
89730da to
deec1e3
Compare
|
/bot run |
|
PR_Github #16882 [ run ] triggered by Bot |
|
PR_Github #16882 [ run ] completed with state |
jiaganc
force-pushed
the
dev-jiaganc-fix-precompiled-nanobind
branch
from
deec1e3 to
5a7bd3f
Compare
|
/bot run |
|
PR_Github #17163 [ run ] triggered by Bot |
|
PR_Github #17163 [ run ] completed with state |
|
/bot run |
|
PR_Github #17205 [ run ] triggered by Bot |
|
PR_Github #17205 [ run ] completed with state |
jiaganc
force-pushed
the
dev-jiaganc-fix-precompiled-nanobind
branch
from
7f416c5 to
5a7bd3f
Compare
Signed-off-by: Jiagan Cheng <[email protected]>
Signed-off-by: Jiagan Cheng <[email protected]>
jiaganc
force-pushed
the
dev-jiaganc-fix-precompiled-nanobind
branch
from
5a7bd3f to
072c51f
Compare
|
/bot run |
|
PR_Github #17276 [ run ] triggered by Bot |
|
PR_Github #17276 [ run ] completed with state |
4 participants
Summary by CodeRabbit
Bug Fixes
Chores
Description
We switch to nanobind in #6608 and it has different bindings files compared to pybind as shown below. When using precompiled package, only pybind files are copied, so it will fail.
This PR lets
setup.pycopy the nanobind file (i.e.bindings.pyi).Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.