Skip to content

[https://nvbugs/6215736][infra] Unwaive test_fp8_blockscale[throughput_mtp]#14541

Merged
bobboli merged 1 commit into
NVIDIA:mainfrom
bobboli:unwaive-6215736
May 27, 2026
Merged

[https://nvbugs/6215736][infra] Unwaive test_fp8_blockscale[throughput_mtp]#14541
bobboli merged 1 commit into
NVIDIA:mainfrom
bobboli:unwaive-6215736

Conversation

@bobboli
Copy link
Copy Markdown
Collaborator

@bobboli bobboli commented May 26, 2026 •
edited by coderabbitai Bot
Loading

Summary

  • Unwaive accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_fp8_blockscale[throughput_mtp] (nvbugs/6215736).

Test plan

  • CI passes for the unwaived test.

Summary by CodeRabbit

  • Tests
    • Updated test configuration by re-enabling a previously skipped test related to LLM API performance and throughput measurement, expanding test coverage.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

This PR removes a single waived (skipped) test entry from the integration test waiver list. The previously skipped test accuracy/test_llm_api_pytorch.py::TestDeepSeekR1::test_fp8_blockscale[throughput_mtp] is now enabled to run, indicating the underlying issue (nvbugs/6215736) has been resolved.

Changes

Test waiver list update

Layer / File(s) Summary
Test waiver list update
tests/integration/test_lists/waives.txt		 Removed the waived SKIP entry for TestDeepSeekR1::test_fp8_blockscale[throughput_mtp], re-enabling the previously skipped test.

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • jieli-matrix
  • mzweilz
  • ZhanruiSunCh
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete and does not follow the required template structure. Critical sections like 'Description' details and 'Test Coverage' are missing or inadequately filled. Expand the Description section to explain why the test is being unwaived and what the underlying issue resolution is. Complete the Test Coverage section with specific test details.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the main change: removing a waived test entry for test_fp8_blockscale[throughput_mtp] and references the associated bug number nvbugs/6215736.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@bobboli
Copy link
Copy Markdown
Collaborator Author

bobboli commented May 26, 2026

/bot run

@bobboli bobboli changed the title [https://nvbugs/6215736][test] Unwaive test_fp8_blockscale[throughput_mtp] [https://nvbugs/6215736][infra] Unwaive test_fp8_blockscale[throughput_mtp] May 26, 2026
@bobboli bobboli enabled auto-merge (squash) May 26, 2026 05:09
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 26, 2026

PR_Github #50278 [ run ] triggered by Bot. Commit: a93142c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 26, 2026

PR_Github #50278 [ run ] completed with state FAILURE. Commit: a93142c
/LLM/main/L0_MergeRequest_PR pipeline #39808 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

@bobboli bobboli mentioned this pull request May 26, 2026
Closed
1 task
@bobboli
Copy link
Copy Markdown
Collaborator Author

bobboli commented May 26, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 26, 2026

PR_Github #50291 [ run ] triggered by Bot. Commit: a93142c Link to invocation

@bobboli bobboli requested a review from jieli-matrix May 26, 2026 06:12
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 26, 2026

PR_Github #50291 [ run ] completed with state SUCCESS. Commit: a93142c
/LLM/main/L0_MergeRequest_PR pipeline #39821 completed with status: 'SUCCESS'

CI Report

Link to invocation

@bobboli bobboli merged commit 37079f6 into NVIDIA:main May 27, 2026
12 of 15 checks passed
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
@bobboli @bmarimuthu-nv
[https://nvbugs/6215736][infra] Unwaive test_fp8_blockscale[throughpu…
475ee17 
…t_mtp] (NVIDIA#14541)

Signed-off-by: Bo Li <[email protected]>
This was referenced May 28, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieli-matrix jieli-matrix jieli-matrix approved these changes

Assignees

@bobboli bobboli

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobboli @tensorrt-cicd @jieli-matrix