Skip to content

[None][chore] Unwaive test_cp_tp_broadcast_object#14328

Merged
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/unwaive-unittest
May 26, 2026
Merged

[None][chore] Unwaive test_cp_tp_broadcast_object#14328
brb-nv merged 1 commit into
NVIDIA:mainfrom
brb-nv:user/brb/unwaive-unittest

Conversation

@brb-nv
Copy link
Copy Markdown
Collaborator

@brb-nv brb-nv commented May 20, 2026 •
edited by coderabbitai Bot
Loading

Description

I'm not able to reproduce the issue reported here despite running the test 50 times locally: https://nvbugspro.nvidia.com/bug/6132301.

So, I'm unwaiving.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Summary by CodeRabbit

  • Tests
    • Removed a test waiver to enable execution of a previously skipped test case.

Review Change Stack

@brb-nv brb-nv requested a review from pcastonguay May 20, 2026 01:25
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a88a7f01-db10-402c-8945-dba8bc10491a

📥 Commits

Reviewing files that changed from the base of the PR and between 77db08d and ab2ad09.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
📝 Walkthrough

Walkthrough

This PR removes a single SKIP waiver entry from the integration test waiver list for the test_cp_tp_broadcast_object[tp_cp_broadcast-list] test case, allowing it to run in the test suite instead of being skipped.

Changes

Test Waiver Update

Layer / File(s) Summary
Remove tp_cp_broadcast_object test waiver
tests/integration/test_lists/waives.txt		 The SKIP waiver for unittest/_torch/ray_orchestrator/multi_gpu/test_ops.py::test_cp_tp_broadcast_object[tp_cp_broadcast-list] is removed, unskipping the test.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#14103: Modifies tests/integration/test_lists/waives.txt to remove a test waiver entry, similar pattern of unskipping tests.
  • NVIDIA/TensorRT-LLM#14058: Also removes a waiver entry from the same test waiver file to re-enable a previously skipped test.
  • NVIDIA/TensorRT-LLM#13877: Modifies the waiver file by removing a test waiver entry to unskip a specific test case.

Suggested reviewers

  • pcastonguay
  • suyoggupta
  • peihu-nv
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: removing a waiver entry for the test_cp_tp_broadcast_object test, making it no longer skipped.
Description check ✅ Passed The description explains the issue, the reason for the change, and includes proper PR checklist completion, though it uses minimal detail for a straightforward maintenance change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@brb-nv
Copy link
Copy Markdown
Collaborator Author

brb-nv commented May 20, 2026

/bot run --stage-list "DGX_H100-2_GPUs-PyTorch-Ray-1"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 20, 2026

PR_Github #49303 [ run ] triggered by Bot. Commit: ab2ad09 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 20, 2026

PR_Github #49303 [ run ] completed with state SUCCESS. Commit: ab2ad09
/LLM/main/L0_MergeRequest_PR pipeline #38965 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@shuyixiong shuyixiong self-requested a review May 20, 2026 06:26
shuyixiong
shuyixiong approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shuyixiong shuyixiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brb-nv
Copy link
Copy Markdown
Collaborator Author

brb-nv commented May 20, 2026

/bot run

@brb-nv brb-nv enabled auto-merge (squash) May 20, 2026 16:41
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 20, 2026

PR_Github #49454 [ run ] triggered by Bot. Commit: ab2ad09 Link to invocation

@brb-nv brb-nv disabled auto-merge May 20, 2026 16:53
@brb-nv brb-nv enabled auto-merge (squash) May 20, 2026 16:53
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 21, 2026

PR_Github #49454 [ run ] completed with state ABORTED. Commit: ab2ad09

Link to invocation

@brb-nv brb-nv force-pushed the user/brb/unwaive-unittest branch from ab2ad09 to a12a140 Compare May 26, 2026 18:58
@brb-nv
Copy link
Copy Markdown
Collaborator Author

brb-nv commented May 26, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 26, 2026

PR_Github #50379 [ run ] triggered by Bot. Commit: a12a140 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented May 26, 2026

PR_Github #50379 [ run ] completed with state SUCCESS. Commit: a12a140
/LLM/main/L0_MergeRequest_PR pipeline #39906 completed with status: 'SUCCESS'

CI Report

Link to invocation

@brb-nv brb-nv merged commit a23207f into NVIDIA:main May 26, 2026
7 checks passed
bmarimuthu-nv pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request May 28, 2026
@brb-nv @bmarimuthu-nv
[None][chore] Unwaive test_cp_tp_broadcast_object (NVIDIA#14328)
2e941c0 
Signed-off-by: Balaram Buddharaju <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shuyixiong shuyixiong shuyixiong approved these changes

@pcastonguay pcastonguay Awaiting requested review from pcastonguay

Assignees

@brb-nv brb-nv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brb-nv @tensorrt-cicd @shuyixiong