Skip to content

[None][infra] Add users to blossom-ci allowlist#13951

Merged
yuanjingx87 merged 1 commit into
NVIDIA:mainfrom
yuanjingx87:user/yuanjingx/update_allowlist_20260509
May 11, 2026
Merged

[None][infra] Add users to blossom-ci allowlist#13951
yuanjingx87 merged 1 commit into
NVIDIA:mainfrom
yuanjingx87:user/yuanjingx/update_allowlist_20260509

Conversation

@yuanjingx87
Copy link
Copy Markdown
Collaborator

@yuanjingx87 yuanjingx87 commented May 10, 2026

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow authorization configuration to manage operational access controls.

Review Change Stack

Description

Add new users to the allowlist

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@yuanjingx87
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "No need to run CI"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2601f4c9-ba88-46b4-9e46-d05b66ae3f0b

📥 Commits

Reviewing files that changed from the base of the PR and between c2e0379 and 868beee.

📒 Files selected for processing (1)
  • .github/workflows/blossom-ci.yml

📝 Walkthrough

Walkthrough

Authorization allowlist for CI bot-triggered operations in the blossom-ci workflow is updated with three additional GitHub actor usernames: JacobHu-NV, shikicloud, and tfogal.

Changes

CI Authorization Allowlist

Layer / File(s) Summary
Authorization Allowlist
.github/workflows/blossom-ci.yml
Three GitHub usernames (JacobHu-NV, shikicloud, tfogal) are added to the Authorization job's allowlist at lines 151, 283, and 307.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/TensorRT-LLM#13146: Both PRs modify the same .github/workflows/blossom-ci.yml Authorization job allowlist by adding additional GitHub actor usernames.

Suggested reviewers

  • tburt-nv
  • mlefeb01
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is incomplete. While it includes basic information ('Add new users to the allowlist'), it lacks details about which specific users are being added and why, and the Test Coverage section is entirely empty. Expand the Description section to explain which users are being added (JacobHu-NV, shikicloud, tfogal) and the reason for adding them. Additionally, clarify why test coverage is not applicable for this infrastructure change, or add relevant tests if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding users to the blossom-ci allowlist, following the required format with ticket reference and type.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47541 [ skip ] triggered by Bot. Commit: 868beee Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #47541 [ skip ] completed with state SUCCESS. Commit: 868beee
Skipping testing for commit 868beee

Link to invocation

@yuanjingx87 yuanjingx87 merged commit 5f3fd3a into NVIDIA:main May 11, 2026
12 of 13 checks passed
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants