[None][chore] Add CODEOWNERS mappings for @NVIDIA/trt-llm-multimodal-devs#13110
Conversation
…devs Add code ownership rules for the new multimodal team covering: - Shared multimodal infrastructure (inputs, encoder framework, C++ code) - VLM models without a dedicated team (siglip, llava_next, qwen3vl, etc.) - Multimodal tests, examples, docs, and serving utils - Co-ownership on existing VLM model rules (gemma3vl, clip, phi4mm, etc.) Signed-off-by: venkywonka <[email protected]>
📝 WalkthroughWalkthroughUpdated the CODEOWNERS file to assign the multimodal developers team as code owners for multiple multimodal PyTorch model implementations, tests, shared infrastructure, serving components, and related examples across the repository. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/CODEOWNERS:
- Line 92: The CODEOWNERS contains a duplicate/conflicting rule for
tensorrt_llm/_torch/models/modeling_pixtral.py where the earlier rule that
assigns `@NVIDIA/trt-llm-torch-models-mistral-devs` is overridden by a later rule;
remove the duplicate or merge the Mistral team into the final (last) matching
rule so the last match contains all intended owners (e.g., include
`@NVIDIA/trt-llm-torch-models-mistral-devs` alongside
`@NVIDIA/trt-llm-torch-models-devs` and `@NVIDIA/trt-llm-multimodal-devs` in the
final entry for modeling_pixtral.py) to ensure reviewer routing is unambiguous.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 436118d0-9dec-4f0a-9c25-2d8ac8a187df
📒 Files selected for processing (1)
.github/CODEOWNERS
Remove dead pixtral rule from Mistral section (shadowed by VLMs section) and duplicate nemotron_nas entry. Signed-off-by: venkywonka <[email protected]>
Signed-off-by: venkywonka <[email protected]>
These paths are dated and set for deprecation (TensorRT engine backend, not PyTorch/AutoDeploy): multimodal_model_runner, multimodal_builder, multimodal_encoders, examples/models/core/multimodal. Signed-off-by: venkywonka <[email protected]>
… comment Signed-off-by: venkywonka <[email protected]>
|
/bot skip --comment "no ci for codeowners update" |
|
PR_Github #43823 [ skip ] triggered by Bot. Commit: |
|
PR_Github #43823 [ skip ] completed with state |
Signed-off-by: venkywonka <[email protected]>
|
/bot skip --comment "no ci for codeowners update" |
|
PR_Github #43842 [ skip ] triggered by Bot. Commit: |
|
PR_Github #43842 [ skip ] completed with state |
Signed-off-by: venkywonka <[email protected]>
|
/bot skip --comment "no ci for codeowners update" |
|
PR_Github #43959 [ skip ] triggered by Bot. Commit: |
|
PR_Github #43959 [ skip ] completed with state |
6 participants
Summary
Adds multimodal codeowners
Summary by CodeRabbit