Skip to content

[https://nvbugs/6013562][test] Update waive#12492

Merged
xinhe-nv merged 1 commit into
NVIDIA:mainfrom
xinhe-nv:waive
Mar 24, 2026
Merged

[https://nvbugs/6013562][test] Update waive#12492
xinhe-nv merged 1 commit into
NVIDIA:mainfrom
xinhe-nv:waive

Conversation

@xinhe-nv
Copy link
Copy Markdown
Collaborator

@xinhe-nv xinhe-nv commented Mar 24, 2026 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Tests
    • Updated test configuration to skip an additional test case.

Note: This release contains only internal test configuration updates with no impact to end-user functionality.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@xinhe-nv
update waive
f5dc83b 
Signed-off-by: Xin He (SW-GPU) <[email protected]>
@xinhe-nv xinhe-nv requested a review from ZhanruiSunCh March 24, 2026 09:27
@xinhe-nv xinhe-nv enabled auto-merge (squash) March 24, 2026 09:27
@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Mar 24, 2026

/bot run --stage-list ""

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 24, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

A single test case was added to the waive list to skip accuracy/test_llm_api_pytorch.py::TestGPTOSS::test_eagle3_vswa_reuse_4gpus[two_model] and associated it with issue https://nvbugs/6013562. No other changes were made to the file.

Changes

Cohort / File(s) Summary
Test Waive List
tests/integration/test_lists/waives.txt		 Added SKIP entry for test_eagle3_vswa_reuse_4gpus[two_model] test case linked to bug tracking reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • chzblych
  • EmmaQiaoCh
  • ziyixiong-nv
  • StanleySun639
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template with no actual content filled in. Title, Description, and Test Coverage sections are empty or use placeholder text. Provide a proper PR title following the template format (e.g., [https://nvbugs/6013562][test] Update waive), fill in the Description section explaining why the waive entry is being added, and list relevant tests in Test Coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title '[https://nvbugs/6013562][test] update waive' refers to updating a waive entry and includes a bug tracker reference, which directly relates to the single file change that adds a SKIP entry to the waives.txt file.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)

✅ Unit Test PR creation complete.

  • Create PR with unit tests
  • Commit unit tests in branch waive

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 24, 2026

PR_Github #40100 [ run ] triggered by Bot. Commit: f5dc83b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 24, 2026

PR_Github #40100 [ run ] completed with state SUCCESS. Commit: f5dc83b
/LLM/main/L0_MergeRequest_PR pipeline #31251 (Partly Tested) completed with status: 'SUCCESS'

CI Report

Link to invocation

@xinhe-nv xinhe-nv changed the title [None][test] update waive [https://nvbugs/6013562][test] update waive Mar 24, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 24, 2026

Note

Unit test generation is a public access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Generating unit tests... This may take up to 20 minutes.

@xinhe-nv xinhe-nv changed the title [https://nvbugs/6013562][test] update waive [https://nvbugs/6013562][test] Update waive Mar 24, 2026
@xinhe-nv
Copy link
Copy Markdown
Collaborator Author

xinhe-nv commented Mar 24, 2026

/bot reuse-pipeline

@NVIDIA NVIDIA deleted a comment from coderabbitai Bot Mar 24, 2026
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 24, 2026

PR_Github #40116 [ reuse-pipeline ] triggered by Bot. Commit: f5dc83b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 24, 2026

PR_Github #40116 [ reuse-pipeline ] completed with state SUCCESS. Commit: f5dc83b
Reusing PR_Github #40100 (Partly Tested) for commit f5dc83b

Link to invocation

@xinhe-nv xinhe-nv merged commit b636dcc into NVIDIA:main Mar 24, 2026
13 of 14 checks passed
@xinhe-nv xinhe-nv deleted the waive branch March 24, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanleySun639 StanleySun639 StanleySun639 approved these changes

@ZhanruiSunCh ZhanruiSunCh Awaiting requested review from ZhanruiSunCh

@chzblych chzblych Awaiting requested review from chzblych

Assignees

@xinhe-nv xinhe-nv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xinhe-nv @tensorrt-cicd @StanleySun639