[None][test] Fix lora config less than required config number#12409
Merged
Conversation
Signed-off-by: yufeiwu-nv <[email protected]>
Collaborator
Author
|
/bot skip --comment "only test list modify" |
Contributor
📝 WalkthroughWalkthroughModified LoRA path handling in a performance test's Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/integration/defs/perf/test_perf.py (1)
1-1: Update copyright year to 2026.The file is being modified in 2026, but the copyright header still shows 2022-2025. As per coding guidelines, the year should be updated for modified files.
-# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-FileCopyrightText: Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/integration/defs/perf/test_perf.py` at line 1, Update the SPDX copyright header at the top of the file (the SPDX-FileCopyrightText line) to reflect the current year range by changing "2022-2025" to "2022-2026" so the header reads "... Copyright (c) 2022-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved."
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@tests/integration/defs/perf/test_perf.py`:
- Line 1: Update the SPDX copyright header at the top of the file (the
SPDX-FileCopyrightText line) to reflect the current year range by changing
"2022-2025" to "2022-2026" so the header reads "... Copyright (c) 2022-2026
NVIDIA CORPORATION & AFFILIATES. All rights reserved."
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 53b4f60d-5a27-4049-a3d3-24fbe9bbc788
📒 Files selected for processing (1)
tests/integration/defs/perf/test_perf.py
Collaborator
|
PR_Github #39722 [ skip ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #39722 [ skip ] completed with state |
LarryXFly
approved these changes
Mar 23, 2026
longcheng-nv
pushed a commit
to longcheng-nv/TensorRT-LLM
that referenced
this pull request
Mar 31, 2026
…#12409) Signed-off-by: yufeiwu-nv <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.