Repository navigation
Fix false parser limits in Node assertion templates - #921
Merged
mohgupta-ship-it merged 2 commits intoOct 27, 2026
Merged
Conversation
Signed-off-by: yashrajbasav <[email protected]>
yashrajp22
force-pushed
the
yashraj/fix-javascript-template-completeness
branch
from
October 27, 2026 11:00
f195787 to
cb6c96e
Compare
Signed-off-by: yashrajbasav <[email protected]>
mohgupta-ship-it
approved these changes
Oct 27, 2026
mohgupta-ship-it
deleted the
yashraj/fix-javascript-template-completeness
branch
October 27, 2026 11:19
| from collections.abc import Callable | ||
| from dataclasses import dataclass | ||
|
|
||
| _MAX_SOURCE_CHARS = 1_000_000 |
Member
There was a problem hiding this comment.
these should be really high values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node assertion diagnostics such as
check.equal(actual, expected, `${row.key} is required`)were interpreted as shell command substitutions, producing a falsestatic_parse_limitand failing strict completeness checks.Add bounded recognition of direct diagnostic-template arguments on a verified
node:assertornode:assert/strictimport. Only the proven template delimiters change in the shell-completeness view; raw command checks, finding contents, and source offsets remain intact. Classify.mjsand.cjsconsistently in ordinary files and archive members.Unknown consumers, ambiguous syntax, aliases, shadowing, mutations, interpolation with calls or updates, fragments, and exceeded resource limits retain conservative behavior. TypeScript keeps its existing parser path because postfix and type expressions require different grammar. This covers a deliberately narrow JavaScript subset and assumes ordinary built-in assertion semantics; it does not add general JavaScript dataflow analysis.
Validation on the proposed commit:
All verification above used isolated offline scans with
--no-llm; scanned skill payloads were not executed. Target:main.