Repository navigation
fix: correct wrapper parsing and TP4 batch limits - #917
Merged
Merged
Conversation
yashrajp22
force-pushed
the
yashraj/fix-parser-mcp-completeness
branch
from
October 27, 2026 06:36
fb75f23 to
c07a8a5
Compare
Treat sudo -n as a flag and parse descriptor redirections atomically. Align TP4 batch capacity with the existing 128-file allowance while retaining other resource limits. Extend regression coverage for wrapper parsing, batch boundaries and late failures. Signed-off-by: yashrajbasav <[email protected]>
yashrajp22
force-pushed
the
yashraj/fix-parser-mcp-completeness
branch
from
October 27, 2026 07:02
c07a8a5 to
d988f33
Compare
mohgupta-ship-it
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sudo -n ... 2>&1can be marked partially inspected because the parser consumes-nas an operand option and splits descriptor redirections incorrectly. Separately, TP4 stops larger skills at 64 batches despite allowing 128 files.Treat sudo's
-nas a flag, parse descriptor redirections atomically, and align TP4's batch allowance with the existing 128-file limit. Dynamic or malformed commands remain incomplete; byte, token, runtime, file and finding limits remain enforced. Added regression coverage includes Python wrapper names, shell options and redirections, 64/65/128/129 batch boundaries, late provider/size/deadline failures, source ranges, and the finding cap.This PR targets main. Main already contains the wrapper-boundary fix from #779, so that backport is no longer part of this diff. For a 2.13.2 release based on current 2.13.1, cherry-pick #779 (
623284fa9e275673ba69d3e82b793bf1aaf15057) first if it is absent, then this PR. Preserve the release branch's existing Python ownership guards when resolving backport conflicts.Validation for
d988f33d13b82fb41d696c2cc5a52b106e75e78b, using fresh base/HEAD wheels and main's locked dependencies in isolated containers:Two schema-invalid responses during the live UART scan recovered through existing retries. This PR does not change malformed-response handling; persistent failures remain incomplete. Existing missing-reference warnings still leave the affected full-skill reports partial. Live coverage is limited to this configured model/endpoint, and the CAD acceptance covers TP4. Full-suite CI is separate from these local checks.
The maximum TP4 batch allowance doubles; byte, token, runtime, file and finding limits remain enforced. Workbook scope-exclusion acceptance and evaluator chunk limits require separate changes.