Repository navigation
Fix CI parser regressions and isolate TOML service lookup - #1005
Merged
Merged
Conversation
Signed-off-by: yashrajbasav <[email protected]>
This was referenced Nov 3, 2026
Signed-off-by: yashrajbasav <[email protected]>
Signed-off-by: yashrajbasav <[email protected]>
yashrajp22
changed the title
yashrajp22
marked this pull request as ready for review
November 4, 2026 09:27
yashrajp22
added a commit
that referenced
this pull request
Nov 4, 2026
…service lookup Fix bounded multiline printf inspection and keep TOML regression checks independent of vulnerability-service availability. (cherry picked from commit 09178da) Signed-off-by: yashrajbasav <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two independent CI problems: the oversized-TOML regression test depended on live vulnerability-service availability, and bounded shell inspection incorrectly marked some known quoted multiline
printfsubstitutions incomplete.Stub only the vulnerability lookup and its reachability flag in the TOML test. Keep the real parser, original-finding assertion and incomplete-inspection assertion.
Also correct the production parser's quote-boundary proof for bounded literal multiline
printf. Unknown arguments, nested runtime commands, local replacements, incomplete context and existing resource limits remain conservative; destructive-command findings are preserved. PowerShell regression tests now assert their own language behavior directly.Current validation
At
51c2440826e9d24a98dee8e037d233e173dc1df4, 464 focused tests passed from source and 464 from a freshly built, non-editable wheel. Coverage includes LF/CRLF, unresolved/redefined commands, host-language boundaries and retained destructive-command findings. All 138 tracked package files match source. Follow-upf1cb2b88a5a12b60ac773d1761e975b319f89af6only wraps the same expression across lines; its parsed Python structure is identical, and lint/format checks pass.The new offline matrix completed 32 full-skill scans for this PR (base and fix, source and fresh wheel), with all 16 source/wheel pairs matching and every noncoverage finding preserved in the 16 base/fix comparisons. Bounded literal commands become fully inspectable; unknown or redefined commands remain incomplete and destructive findings remain present. The four-PR matrix totals 128 scans.
Real-provider before/after validation completed 8 full-skill scans from source and fresh wheels, covering a redefined command and a broader documentation-conversion skill. Seven have complete AI-stage accounting and no unresolved AI diagnostics. One baseline wheel run retains a developer-intent refusal diagnostic; all four fixed-code runs completed AI review. The redefined-command static limitation stays visible. No scan was rerun to obtain a passing outcome.
Current GitHub CI has five successful checks; the full unit-test job is still running. This PR remains draft pending that result and its prerequisite merges, where applicable.
Historical evidence
At
a8b9216c7adaffb2bbbadd7681ec4edc0d876d23, all 109 tests passed across the TOML regression, vulnerability-client and lockfile modules with networking disabled. Lint and formatting passed. The unchanged main revision failed the original target test offline, reproducing the service-isolation defect. That evidence applies to the earlier test-isolation change, not the current production parser correction.