Skip to content

CLI error messages are parsed as Rich markup, so skillspector mcp drops [mcp] from its install hint #885

Closed

Description

@WeAreResilience

On main at 95a52d8, the CLI prints exception text with err_console.print(f"[red]Error:[/red] {e}") in cli.py (for example lines 396, 699, 743, 908 and 3413), so any brackets in the message are read as Rich markup.

Repro in a fresh venv with pip install git+https://github.com/NVIDIA/SkillSpector:

  • skillspector mcp prints Install it with: pip install 'skillspector'. The message in mcp_server.py:268 says skillspector[mcp], and following the printed advice doesn't install the extra.
  • skillspector scan "skills[old]/demo" reports Cannot determine input type for: skills/demo.
  • skillspector scan "nope[/x]" ends in a MarkupError traceback instead of the usual exit-2 error.

#725 fixed the same class for terminal reports (terminal_text.visible_terminal_text) and #734 for batch output; the CLI error lines weren't covered.

A fix would escape the interpolated text with rich.markup.escape at each of those call sites, with a CLI test per case above. Would a PR for that be welcome?

Activity

  1. farzamfallahi commented on Oct 21, 2026

    @farzamfallahi

    I'd like to take this one. I'll render the CLI error text literally (Rich Text segments, the shared terminal_text helper, emoji disabled) following the approach from #725 and #734, with a CLI test for each of the three repro commands. Happy to step aside if you're already working on a PR.

  2. added a commit that references this issue on Oct 28, 2026
    f1778f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions