You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Meta-review can attach assessments to the wrong finding and misreport review status #667
Meta-review can attach a response to the wrong finding when two findings share a rule and source line. Reports also group different unconfirmed outcomes together. A coverage finding added after meta-review can make a review phase appear to have failed even when no review was required.
Evidence
A test with controlled model responses and two different findings on the same rule/line attached an assessment to the wrong finding.
Per-finding review results do not consistently distinguish model disagreement, an omitted decision and a failed call.
Findings added during finalization can be counted as work that the earlier meta-review phase should have reviewed.
The controlled-response test checks the matching logic; it does not measure model accuracy.
Expected behavior
Each assessment should stay attached to the finding it reviewed. Reports should preserve the original evidence and distinguish a completed assessment from missing or failed review. Findings added after meta-review should not create a false model-call failure. Actual gaps in review should still be reported.
Keep the existing scoring and completeness behavior. LLM disagreement or a missing review must not automatically clear a deterministic finding.
Related work
PR #616 preserves LLM finding fields; PR #663 names analyzers in status rows. These changes do not fix finding-to-assessment matching or distinguish the per-finding review outcomes described above.
Resolution verified on 2026-10-04: PR #702 has merged, and GitHub automatically closed this issue.
The fix binds assessments using finding IDs with conservative legacy-location fallback, distinguishes disagreement/missing/failed review outcomes, and preserves the meta-review requirement snapshot so finalization-added coverage findings do not invent a failed review call. Deterministic findings and evidence remain intact; this is not automatic clearing of findings on model disagreement.
Verification on merged main (701baea): the meta-analyzer, inspection-ledger finalization, and semantic-runtime suites passed (194 tests). Provider behavior was mocked; no live LLM call was required. The earlier merged PR #663 was a separate status-label change, not the assessment fix.
Activity
rng1995 commentedon Oct 4, 2026
Resolution verified on 2026-10-04: PR #702 has merged, and GitHub automatically closed this issue.
The fix binds assessments using finding IDs with conservative legacy-location fallback, distinguishes disagreement/missing/failed review outcomes, and preserves the meta-review requirement snapshot so finalization-added coverage findings do not invent a failed review call. Deterministic findings and evidence remain intact; this is not automatic clearing of findings on model disagreement.
Verification on merged main (701baea): the meta-analyzer, inspection-ledger finalization, and semantic-runtime suites passed (194 tests). Provider behavior was mocked; no live LLM call was required. The earlier merged PR #663 was a separate status-label change, not the assessment fix.